Use --library-manager=false as default
#119
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
approved these changes
Dec 18, 2020
per1234
force-pushed
the
per1234/library-manager-false-default
branch
from
1cb4d4b to
b8494f7
Compare
Previously, the default check mode for library projects was `--library-manager=submit`. The reasoning was this would ensure that no incompatibilities with Library Manager would be introduced during the development phase of libraries. However, the extra checks by default might make the tool less friendly to first time users who already have their library in Library Manager but aren't using the appropriate setting due to not having read the documentation.
per1234
force-pushed
the
per1234/library-manager-false-default
branch
from
b8494f7 to
30c2532
Compare
|
We decided to leave this setting as is and instead improve the Library Manager-related rule messages (06acd04) to make the situation more clear to the user when they get a spurious error due to using an incorrect |
per1234
added
conclusion: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the default check mode for library projects was
--library-manager=submit. The reasoning was this wouldensure that no incompatibilities with Library Manager would be introduced during the development phase of libraries.
However, the extra checks by default might make the tool less friendly to first time users who already have their
library in Library Manager but aren't using the appropriate setting due to not having read the documentation.
As requested at 5f24a05