Skip to content

Commit 1cb4d4b

Browse files
committed
Use --library-manager=false as default
Previously, the default check mode for library projects was `--library-manager=submit`. The reasoning was this would ensure that no incompatibilities with Library Manager would be introduced during the development phase of libraries. However, the extra checks by default might make the tool less friendly to first time users who already have their library in Library Manager but aren't using the appropriate setting due to not having read the documentation.
1 parent 54e1502 commit 1cb4d4b

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

configuration/defaults.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ var defaultCheckModes = map[projecttype.Type]map[checkmode.Type]bool{
3939
checkmode.Strict: false,
4040
checkmode.Specification: true,
4141
checkmode.Permissive: false,
42-
checkmode.LibraryManagerSubmission: true,
42+
checkmode.LibraryManagerSubmission: false,
4343
checkmode.LibraryManagerIndexed: false,
4444
checkmode.Official: false,
4545
},

test/test_all.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -181,13 +181,18 @@ def test_version(run_command):
181181
def test_arduino_lint_official(run_command):
182182
project_path = test_data_path.joinpath("ARDUINO_LINT_OFFICIAL")
183183

184-
result = run_command(cmd=[project_path])
184+
# Test default to ARDUINO_LINT_OFFICIAL="false"
185+
result = run_command(cmd=["--library-manager", "submit", project_path])
185186
assert not result.ok
186187

187-
result = run_command(cmd=[project_path], custom_env={"ARDUINO_LINT_OFFICIAL": "true"})
188+
result = run_command(
189+
cmd=["--library-manager", "submit", project_path], custom_env={"ARDUINO_LINT_OFFICIAL": "true"}
190+
)
188191
assert result.ok
189192

190-
result = run_command(cmd=[project_path], custom_env={"ARDUINO_LINT_OFFICIAL": "false"})
193+
result = run_command(
194+
cmd=["--library-manager", "submit", project_path], custom_env={"ARDUINO_LINT_OFFICIAL": "false"}
195+
)
191196
assert not result.ok
192197

193198
result = run_command(cmd=[project_path], custom_env={"ARDUINO_LINT_OFFICIAL": "foo"})

0 commit comments

Comments
 (0)