Skip to content

Improve error output #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 14, 2020
Merged

Improve error output #102

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef27958
Disable logging immediately
per1234 Dec 11, 2020
c09c82d
Use clear and consistent error output
per1234 Dec 11, 2020
ab81928
Panic on inability to resolve working directory
per1234 Dec 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Panic on inability to resolve working directory 
This is an unexpected error with no clear cause, so the panic is more appropriate.
  • Loading branch information
@per1234
per1234 committed Dec 14, 2020
commit ab81928580d47ce3170f96cdcdbda2c35f36c1f4
2 changes: 1 addition & 1 deletion configuration/configuration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ func Initialize(flags *pflag.FlagSet, projectPaths []string) error {
// Default to using current working directory.
workingDirectoryPath, err := os.Getwd()
if err != nil {
return fmt.Errorf("Error when setting default PROJECT_PATH argument: %s", err)
panic(err)
}
targetPaths.Add(paths.New(workingDirectoryPath))
} else {
Expand Down