Improve error output #102
Merged
Improve error output #102
+28
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
approved these changes
Dec 14, 2020
By default, logging is disabled, but this was previously done in configuration.Initialize(), meaning that any log output above the default level made before that part of the configuration ran was still displayed.
Previously, it was not always clear that the error messages were such. Adding a prefix to the feedback.Error*() output ensures this will be clear and that the error messages will follow a consistent format.
This is an unexpected error with no clear cause, so the panic is more appropriate.
per1234
force-pushed
the
per1234/improve-output2
branch
from
cc5e4fb to
ab81928
Compare
per1234
added
topic: code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.