Skip to content

#1529 Avoid using reportResult if installing lib/core #1530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Conversation

kittaakos
Copy link
Contributor

Motivation

To fix the persistent error (see #1529) when installing a library or platform. As part of the arduino/arduino-cli#1875 the DownloadProgress(Start|Update|End) APIs have been unified. Besides the index updates, the lib/platform install started to use the same API as the index update, but IDE2 was not prepared for this. The PR should fix the bug by avoiding calling non-existing IDE2 code when installing a lib/platform. For the index updates, everything remains the same in IDE2.

Change description

Other information

To verify:

  • Start IDE2 from a terminal or open DevTools in the browser window,
  • Install a couple of libraries and platforms. It should work. It fails from the main (61a11a0)

Closes #1529

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

Closes #1529

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Oct 5, 2022
@kittaakos kittaakos requested review from AlbyIanna and per1234 October 5, 2022 13:34
@kittaakos kittaakos merged commit 019b2d5 into main Oct 7, 2022
@kittaakos kittaakos deleted the #1529 branch October 7, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
2 participants