-
-
Notifications
You must be signed in to change notification settings - Fork 398
[breaking] Refactor DownloadProgress
gRPC message: more clear field meaning.
#1875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3f11693
to
9a43ead
Compare
Codecov ReportBase: 36.58% // Head: 36.77% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1875 +/- ##
==========================================
+ Coverage 36.58% 36.77% +0.19%
==========================================
Files 231 231
Lines 19696 19685 -11
==========================================
+ Hits 7206 7240 +34
+ Misses 11659 11614 -45
Partials 831 831
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
6b5d96c
to
8a440f5
Compare
805f6bc
to
12ce8fc
Compare
12ce8fc
to
13b3f85
Compare
Co-authored-by: per1234 <accounts@perglass.com>
@cmaglie, could you please merge this PR if it's ready? Thank you! |
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)Refactor the
DownloadProgress
messages.It's not very clear how the fields in the progress reports are populated.
The new message structure should be much more clearer.
Yes