Skip to content

#1084, #1156 Various library/platform index update fixes #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2022
Merged

#1084, #1156 Various library/platform index update fixes #1418

merged 1 commit into from
Oct 5, 2022

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Sep 9, 2022 •
edited
Loading

Motivation

Change description

Other information

Closes #1084
Closes #1156

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project topic: CLI Related to Arduino CLI labels Sep 9, 2022
@kittaakos kittaakos changed the title #1084, #1156 Various library and platform index fixes #1084, #1156 Various library/platform index update fixes Sep 9, 2022
@kittaakos kittaakos added the status: on hold Do not proceed at this time label Sep 21, 2022
@kittaakos kittaakos force-pushed the #1156 branch 3 times, most recently from e248e07 to 8c466d2 Compare September 29, 2022 14:19
@kittaakos kittaakos marked this pull request as ready for review September 29, 2022 14:26
@per1234 per1234 mentioned this pull request Oct 2, 2022
Merged
5 tasks
Various library/platform index update fixes
0a02d77 
 - IDE2 can start if the package index download fails. Closes arduino#1084
 - Split the lib and platform index update. Closes arduino#1156

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
per1234
per1234 approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is working perfectly for me. I verified it fixes #1084 (comment)

This provides a significant improvement to the user experience on IDE startup and installing 3rd party boards platforms via Boards Manager.

Thanks Akos!

AlbyIanna
AlbyIanna approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested it thoroughly but code looks fine to me. Green light 🟢

@kittaakos kittaakos merged commit 0c20ae0 into arduino:main Oct 5, 2022
@per1234 per1234 mentioned this pull request Oct 5, 2022
Closed
@per1234 per1234 mentioned this pull request Oct 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbyIanna AlbyIanna AlbyIanna approved these changes

@per1234 per1234 per1234 approved these changes

Assignees
No one assigned
Labels
status: on hold Do not proceed at this time topic: CLI Related to Arduino CLI topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
3 participants
@kittaakos @AlbyIanna @per1234