Skip to content

IDE2 shows SOCKS5 instead of SOCKS in the Settings > Network tab #1782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
kittaakos opened this issue Dec 21, 2022 · 1 comment
Closed
3 tasks done

IDE2 shows SOCKS5 instead of SOCKS in the Settings > Network tab #1782

kittaakos opened this issue Dec 21, 2022 · 1 comment
Assignees
Labels
conclusion: declined Will not be worked on topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@kittaakos
Copy link
Contributor

Describe the problem

This is a follow-up of #1776. Originally from here:

Thank you for the help. The code looks good. I agree SOCKS5 would better qualify the protocol in the UI, but the (old) IDE 1.x shows SOCKS.

Screen Shot 2022-12-16 at 17 29 56

We should consider that tutorials, documentation, and screenshots might exist with SOCKS on the Internet. I am OK with the change too.

Acceptance criteria:

  • Decide whether IDE2 can stick to SOCK5 or not.

To reproduce

  • Open IDE2,
  • Open the Settings dialog,
  • Switch to the Network tab,
  • See SOCKS5

Screen Shot 2022-12-21 at 14 36 19

Expected behavior

This is an open question to @ubidefeo and @91volt. Please advise us. Thank you!

Arduino IDE version

3f05396

Operating system

macOS

Operating system version

12.5.1

Additional context

Please align the GH labels if needed. I did not have a better idea. Thank you!

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@kittaakos kittaakos added topic: documentation Related to documentation for the project phase: design Work is in the design phase labels Dec 21, 2022
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project and removed topic: documentation Related to documentation for the project labels Feb 21, 2025
@per1234 per1234 assigned per1234 and unassigned ubidefeo and 91volt Feb 21, 2025
@per1234
Copy link
Contributor

per1234 commented Feb 21, 2025

SOCKS5 is the most technically correct. We haven't received any reports of confusion caused by this change over the two years since it was released.

So I have determined that the current use of "SOCKS5" as the radio button label is fine and no action needs to be taken.

@per1234 per1234 closed this as completed Feb 21, 2025
@per1234 per1234 added conclusion: declined Will not be worked on type: enhancement Proposed improvement and removed phase: design Work is in the design phase type: imperfection Perceived defect in any part of project labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: declined Will not be worked on topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

No branches or pull requests

4 participants