Skip to content

Commit 3f05396

Browse files
wh201906per1234
andauthored
Replace socks with socks5 in proxy protocol (#1776)
The net/http package in arduino-cli supports socks5 as scheme rather than socks. Co-authored-by: per1234 <accounts@perglass.com>
1 parent 644e607 commit 3f05396

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

arduino-ide-extension/src/browser/dialogs/settings/settings-component.tsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -406,7 +406,7 @@ export class SettingsComponent extends React.Component<
406406
}
407407
onChange={this.socksProtocolDidChange}
408408
/>
409-
SOCKS
409+
SOCKS5
410410
</label>
411411
</form>
412412
<div className="flex-line proxy-settings">
@@ -682,7 +682,7 @@ export class SettingsComponent extends React.Component<
682682
): void => {
683683
if (this.state.network !== 'none') {
684684
const network = this.cloneProxySettings;
685-
network.protocol = event.target.checked ? 'http' : 'socks';
685+
network.protocol = event.target.checked ? 'http' : 'socks5';
686686
this.setState({ network });
687687
}
688688
};
@@ -692,7 +692,7 @@ export class SettingsComponent extends React.Component<
692692
): void => {
693693
if (this.state.network !== 'none') {
694694
const network = this.cloneProxySettings;
695-
network.protocol = event.target.checked ? 'socks' : 'http';
695+
network.protocol = event.target.checked ? 'socks5' : 'http';
696696
this.setState({ network });
697697
}
698698
};

0 commit comments

Comments
 (0)