Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: arduino/arduino-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e0b81f4
Choose a base ref
...
head repository: arduino/arduino-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e468cf7
Choose a head ref
  • 7 commits
  • 33 files changed
  • 5 contributors

Commits on Nov 29, 2022

  1. [breaking] Fixed detection of double-install using lib install with…

    … `--git-url` or `--zip-path` (#1983)
    
    * Remove useless logging
    
    The errors are already reported upstream via returned `err` value
    
    * librariesmanager.InstallPrerequisiteCheck signature change
    
    It now accepts library name and version as single arguments since we are
    going to use this function also for libraries not present in the index.
    
    * Added integration test
    
    * Fixed `lib install --git-url` pre-install checks
    
    Now it performs all the needed checks to avoid multiple installations.
    
    * Added test for double install with -.zip-path flag
    
    * Fixed `lib install --zip-path` pre-install checks
    
    Now it performs all the needed checks to avoid multiple installations
    
    * Simplified loop in LibraryInstall function
    
    * Factored some of the checks in LibrariesManager.InstallPrerequisiteCheck
    
    They were duplicated and spread around all the library install
    functions.
    
    * Refactored LibrariesManager.getLibrariesDir function
    
    This helped to find out 2 places where the `installDir` was unnecessary.
    
    * Factored all duplicated code for importing a library from a directory
    
    * Updated docs
    
    * Fixed integration test
    
    The installation folder is now taken from the `name` field in `library.properties`.
    
    * Update docs/UPGRADING.md
    
    Co-authored-by: Umberto Baldi <34278123+umbynos@users.noreply.github.com>
    
    Co-authored-by: Umberto Baldi <34278123+umbynos@users.noreply.github.com>
    cmaglie and umbynos authored Nov 29, 2022
    Configuration menu
    Copy the full SHA
    c570916 View commit details
    Browse the repository at this point in the history
  2. Fix sketch new default overwriting behavior (#1993)

    * Check .ino sketch file exists in path before creating a new one
    
    Running "arduino-cli sketch new ." from a sketch directory overwrites an existing .ino sketch file, without asking for confirmation. This fix introduces a check to verify if the specified path already
    contains a .ino sketch file. If it does, an error is returned, otherwise a new sketch is created as usual.
    
    * Add test to check if sketch new does not overwrite an already existing .ino sketch file
    
    * Add --overwrite flag to sketch new command
    
    Using the "--overwrite" flag, allows to create a new sketch overwriting an existing one.
    MatteoPologruto authored Nov 29, 2022
    Configuration menu
    Copy the full SHA
    ab73719 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. Enable sketch archive overrides using overwrite flag (#1994)

    * Make includeBuildDir private
    
    * Enable sketch archive override using the --overwrite flag
    
    * Add test to verify the changes
    MatteoPologruto authored Nov 30, 2022
    Configuration menu
    Copy the full SHA
    76ddec8 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2022

  1. [skip-changelog] Eliminate empty lines produced by board details -b (

    …#1997)
    
    * Eliminate blank line between required tools row entries
    
    * Fix Programmers ID typo and modify tests accordingly
    
    * Reduce spacing between "Required tool" columns
    
    Splitting the table produced by `board details` after `Platform checksum` resets both the average length and the variance of the following cells, thus reducing the space between entries.
    MatteoPologruto authored Dec 1, 2022
    Configuration menu
    Copy the full SHA
    210dda4 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2022

  1. Configuration menu
    Copy the full SHA
    82dc5dd View commit details
    Browse the repository at this point in the history
  2. [skip-changelog] Migrate twelve tests from test_lib.py to `lib_test…

    ….go` (#1989)
    
    * Migrate TestList from test_lib.py to lib_test.go
    
    * Migrate TestListExitCode from test_lib.py to lib_test.go
    
    * Migrate TestListWithFqbn from test_lib.py to lib_test.go
    
    * Migrate TestListProvidesIncludesFallback from test_lib.py to lib_test.go
    
    * Migrate TestLibDownload from test_lib.py to lib_test.go
    
    * Migrate TestInstall from test_lib.py to lib_test.go
    
    * Migrate TestInstallLibraryWithDependencies from test_lib.py to lib_test.go
    
    * Migrate TestInstallNoDeps from test_lib.py to lib_test.go
    
    * Migrate TestInstallWithGitUrl from test_lib.py to lib_test.go
    
    * Migrate TestInstallWithGitUrlFragmentAsBranch from test_lib.py to lib_test.go
    
    * Migrate TestUpdateIndex from test_lib.py to lib_test.go
    
    * Migrate TestUninstall from test_lib.py to lib_test.go
    
    * Reduce quoting using verbatim strings and improve jq queries
    
    Co-authored-by: Cristian Maglie <c.maglie@bug.st>
    
    Co-authored-by: Cristian Maglie <c.maglie@bug.st>
    MatteoPologruto and cmaglie authored Dec 2, 2022
    Configuration menu
    Copy the full SHA
    f9a3b36 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. Configuration menu
    Copy the full SHA
    e468cf7 View commit details
    Browse the repository at this point in the history
Loading