Skip to content

[skip-changelog]Update installed.json with newer entries #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MatteoPologruto
Copy link
Contributor

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Code imperfection fix

What is the current behavior?

installed.json is out of date. This causes TestCoreInstallCreatesInstalledJson.

What is the new behavior?

Adding and modifying some entries solves the issue. However, this is just a temporary workaround. In the future, a better solution would be to modify the test in some way.

Does this PR introduce a breaking change, and is titled accordingly?

No

@MatteoPologruto MatteoPologruto added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Dec 2, 2022
@MatteoPologruto MatteoPologruto self-assigned this Dec 2, 2022
@MatteoPologruto MatteoPologruto marked this pull request as ready for review December 2, 2022 14:56
@MatteoPologruto MatteoPologruto merged commit 82dc5dd into arduino:master Dec 2, 2022
@MatteoPologruto MatteoPologruto deleted the update-installed-json branch December 2, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants