-
-
Notifications
You must be signed in to change notification settings - Fork 415
Comparing changes
Open a pull request
base repository: arduino/arduino-cli
base: d5c39ce
head repository: arduino/arduino-cli
compare: 52499a9
- 16 commits
- 27 files changed
- 3 contributors
Commits on Aug 8, 2022
-
[skip-changelog] [breaking] Downloaders/Installers refactor (#1809)
* Made PackageManager.TempDir private * Merged InstallToolRelease function into the proper packagemanager method * Moved uninstallToolRelease into the proper packagamanger method * Moved uninstallPlatformRelease into the proper packagamanger method * Moved downloadToolRelease into the proper packagamanger method * Merged downloadTool with the proper packagamanger method * Merged downloadPlatform with the proper packagamanger method * Moved installPlatform into a packagamanger method * Moved upgradePlatform into a packagamanger method * Made PackageManager.Log field private * Removed the massive code duplication in the 'upgrade' command * Removed the massive code duplication in the 'outdated' command * Updated docs * Update arduino/cores/packagemanager/install_uninstall.go Co-authored-by: per1234 <accounts@perglass.com> * Update arduino/cores/packagemanager/install_uninstall.go Co-authored-by: per1234 <accounts@perglass.com> Co-authored-by: per1234 <accounts@perglass.com>
Configuration menu - View commit details
-
Copy full SHA for c7163b7 - Browse repository at this point
Copy the full SHA c7163b7View commit details
Commits on Aug 9, 2022
-
[skip changelog] Remove spurious argument from error message (#1827)
`github.com/arduino/arduino-cli/i18n.Tr` provides a `fmt.Printf`-style interface, where the first argument may serve as a template filled by subsequent arguments according to its format verbs. This call contains a subsequent argument, but no verb in the format string to use it. This generates some cryptic content in the error message. For example: Error during install: Error downloading tool arduino:bossac@1.7.0-arduino3: no versions available for the current OS%!(EXTRA *cores.ToolRelease=arduino:bossac@1.7.0-arduino3) The tool name is already provided in the correctly configured `Message` field of the error, so there is no need to include it in the `Cause` field as well, so the spurious argument can be removed entirely rather than the alternative fix of adjusting the format string argument. I suspect the spurious argument was simply the result of a copy/paste error.
Configuration menu - View commit details
-
Copy full SHA for 9075512 - Browse repository at this point
Copy the full SHA 9075512View commit details -
Improved streaming of pluggable-discoveries events (WIP)
Now the DiscoveryManager is able to start the discoveries and add/remove them in a thread-safe way. Also the watchers may connect and disconnect seamlessly at any time, the incoming events from the discovery are broadcasted correctly to each active watcher. This refactoring dramatically simplifies the DiscoveryManager design.
Configuration menu - View commit details
-
Copy full SHA for 9cc1eef - Browse repository at this point
Copy the full SHA 9cc1eefView commit details -
Configuration menu - View commit details
-
Copy full SHA for ec8e53e - Browse repository at this point
Copy the full SHA ec8e53eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 76ceecc - Browse repository at this point
Copy the full SHA 76ceeccView commit details -
Configuration menu - View commit details
-
Copy full SHA for d72db2f - Browse repository at this point
Copy the full SHA d72db2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9074683 - Browse repository at this point
Copy the full SHA 9074683View commit details -
Configuration menu - View commit details
-
Copy full SHA for 851957d - Browse repository at this point
Copy the full SHA 851957dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b1f6d0e - Browse repository at this point
Copy the full SHA b1f6d0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 32aa138 - Browse repository at this point
Copy the full SHA 32aa138View commit details -
Factored subrotuine into a function
it will be useful in the next commits.
Configuration menu - View commit details
-
Copy full SHA for 5330736 - Browse repository at this point
Copy the full SHA 5330736View commit details -
Do not cache ports in the DiscoveryClient
there is already a cache in the DiscoveryManager there is no need to duplicate it.
Configuration menu - View commit details
-
Copy full SHA for 9833534 - Browse repository at this point
Copy the full SHA 9833534View commit details -
Discovery: eventChan must be protected by mutex when doing START_SYNC
otherwise the discovery may send some events before the eventChan is setup (and those events will be lost)
Configuration menu - View commit details
-
Copy full SHA for 2e9eb5f - Browse repository at this point
Copy the full SHA 2e9eb5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 285452f - Browse repository at this point
Copy the full SHA 285452fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1be67ef - Browse repository at this point
Copy the full SHA 1be67efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 52499a9 - Browse repository at this point
Copy the full SHA 52499a9View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff d5c39ce...52499a9