Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: arduino/arduino-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d5c39ce
Choose a base ref
...
head repository: arduino/arduino-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 52499a9
Choose a head ref
  • 16 commits
  • 27 files changed
  • 3 contributors

Commits on Aug 8, 2022

  1. [skip-changelog] [breaking] Downloaders/Installers refactor (#1809)

    * Made PackageManager.TempDir private
    
    * Merged InstallToolRelease function into the proper packagemanager method
    
    * Moved uninstallToolRelease into the proper packagamanger method
    
    * Moved uninstallPlatformRelease into the proper packagamanger method
    
    * Moved downloadToolRelease into the proper packagamanger method
    
    * Merged downloadTool with the proper packagamanger method
    
    * Merged downloadPlatform with the proper packagamanger method
    
    * Moved installPlatform into a packagamanger method
    
    * Moved upgradePlatform into a packagamanger method
    
    * Made PackageManager.Log field private
    
    * Removed the massive code duplication in the 'upgrade' command
    
    * Removed the massive code duplication in the 'outdated' command
    
    * Updated docs
    
    * Update arduino/cores/packagemanager/install_uninstall.go
    
    Co-authored-by: per1234 <accounts@perglass.com>
    
    * Update arduino/cores/packagemanager/install_uninstall.go
    
    Co-authored-by: per1234 <accounts@perglass.com>
    
    Co-authored-by: per1234 <accounts@perglass.com>
    cmaglie and per1234 authored Aug 8, 2022
    Configuration menu
    Copy the full SHA
    c7163b7 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2022

  1. [skip changelog] Remove spurious argument from error message (#1827)

    `github.com/arduino/arduino-cli/i18n.Tr` provides a `fmt.Printf`-style interface, where the first argument may serve as
    a template filled by subsequent arguments according to its format verbs.
    
    This call contains a subsequent argument, but no verb in the format string to use it. This generates some cryptic
    content in the error message.
    
    For example:
    
    Error during install: Error downloading tool arduino:bossac@1.7.0-arduino3: no versions available for the current OS%!(EXTRA *cores.ToolRelease=arduino:bossac@1.7.0-arduino3)
    
    The tool name is already provided in the correctly configured `Message` field of the error, so there is no need to
    include it in the `Cause` field as well, so the spurious argument can be removed entirely rather than the alternative
    fix of adjusting the format string argument. I suspect the spurious argument was simply the result of a copy/paste error.
    per1234 authored Aug 9, 2022
    Configuration menu
    Copy the full SHA
    9075512 View commit details
    Browse the repository at this point in the history
  2. Improved streaming of pluggable-discoveries events (WIP)

    Now the DiscoveryManager is able to start the discoveries and add/remove
    them in a thread-safe way. Also the watchers may connect and disconnect
    seamlessly at any time, the incoming events from the discovery are
    broadcasted correctly to each active watcher.
    
    This refactoring dramatically simplifies the DiscoveryManager design.
    cmaglie committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    9cc1eef View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ec8e53e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    76ceecc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d72db2f View commit details
    Browse the repository at this point in the history
  6. Fixed wrong test

    cmaglie committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    9074683 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    851957d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b1f6d0e View commit details
    Browse the repository at this point in the history
  9. Move Unlock under defer

    cmaglie committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    32aa138 View commit details
    Browse the repository at this point in the history
  10. Factored subrotuine into a function

    it will be useful in the next commits.
    cmaglie committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    5330736 View commit details
    Browse the repository at this point in the history
  11. Do not cache ports in the DiscoveryClient

    there is already a cache in the DiscoveryManager there is no need to
    duplicate it.
    cmaglie committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    9833534 View commit details
    Browse the repository at this point in the history
  12. Discovery: eventChan must be protected by mutex when doing START_SYNC

    otherwise the discovery may send some events before the eventChan is
    setup (and those events will be lost)
    cmaglie committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    2e9eb5f View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    285452f View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    1be67ef View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    52499a9 View commit details
    Browse the repository at this point in the history
Loading