[breaking] Downloaders/Installers refactor #1809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
added
type: enhancement
per1234
requested changes
Aug 5, 2022
Codecov Report
@@ Coverage Diff @@
## master #1809 +/- ##
==========================================
+ Coverage 35.50% 35.87% +0.37%
==========================================
Files 230 231 +1
Lines 19532 19324 -208
==========================================
- Hits 6934 6933 -1
+ Misses 11773 11567 -206
+ Partials 825 824 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Co-authored-by: per1234 <accounts@perglass.com>
Co-authored-by: per1234 <accounts@perglass.com>
cmaglie
force-pushed
the
downloader_installer_refactor
branch
from
65b3621 to
851dfc3
Compare
per1234
approved these changes
Aug 5, 2022
Contributor
per1234
left a comment
per1234
left a comment
There was a problem hiding this comment.
Excellent tidying up of the code happening here.
Thanks Cristian!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Removes a TON of code-duplication. Makes a couple of fields in
PackageManagerprivate.Does this PR introduce a breaking change, and is titled accordingly?
Yes
Other information:
This PR is part of a bigger refactoring to solve concurrency problems in
PackageManager, it started by trying to make thePackageManagerfields private, but making theLogfield private started a massive chain reaction that lead to this PR.