Skip to content

Conversation

@pennam
Copy link
Contributor

@pennam pennam commented Jan 23, 2023

isOtaCapable() can be a static method and changing to static makes possible to call it directly from ArduinoIoTCloud like this:

https://github.com/pennam/ArduinoIoTCloud/blob/d0346cbd88fbb81240eef419ea1dfba7fccee9f6/src/ArduinoIoTCloudTCP.cpp#L209

See :arduino-libraries/ArduinoIoTCloud#351

@pennam pennam requested a review from aentinger January 23, 2023 10:29
@github-actions
Copy link

Memory usage change @ 4cf57c8

Board flash % RAM for global variables %
arduino:mbed:envie_m7 💚 -64 - 0 -0.01 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nicla:nicla_vision 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_opta:opta 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/OTA_Qspi_Flash
flash
% examples/OTA_Qspi_Flash
RAM for global variables
% examples/OTA_SD_Portenta
flash
% examples/OTA_SD_Portenta
RAM for global variables
% examples/OTA_Usage_Portenta
flash
% examples/OTA_Usage_Portenta
RAM for global variables
% examples/OTA_Qspi_Flash_Ethernet
flash
% examples/OTA_Qspi_Flash_Ethernet
RAM for global variables
%
arduino:mbed:envie_m7 -64 -0.01 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nicla:nicla_vision 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_opta:opta 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV
Board,examples/OTA_Qspi_Flash<br>flash,%,examples/OTA_Qspi_Flash<br>RAM for global variables,%,examples/OTA_SD_Portenta<br>flash,%,examples/OTA_SD_Portenta<br>RAM for global variables,%,examples/OTA_Usage_Portenta<br>flash,%,examples/OTA_Usage_Portenta<br>RAM for global variables,%,examples/OTA_Qspi_Flash_Ethernet<br>flash,%,examples/OTA_Qspi_Flash_Ethernet<br>RAM for global variables,%
arduino:mbed:envie_m7,-64,-0.01,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,0,0.0,0,0.0,,,,,0,0.0,0,0.0
arduino:mbed_opta:opta,0,0.0,0,0.0,,,,,0,0.0,0,0.0,0,0.0,0,0.0

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jan 23, 2023
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 (I also had to check the actual code, as the PR only shows the header, but since no member variables are modified, its fine to make it static 👍 )

@pennam
Copy link
Contributor Author

pennam commented Jan 24, 2023

LGTM +1 (I also had to check the actual code, as the PR only shows the header, but since no member variables are modified, its fine to make it static +1 )

👍 👍 Thanks 😉

@pennam pennam merged commit 9120291 into arduino-libraries:main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: code Related to content of the project itself type: enhancement Proposed improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants