Skip to content

Ota: move code #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 28, 2023
Merged

Ota: move code #351

merged 3 commits into from
Feb 28, 2023

Conversation

@pennam
Copy link
Collaborator

@pennam pennam commented Jan 20, 2023 •
edited
Loading

Following 1ab8b3f

Tests:

Board OTA
NANO RP 2040 Connect :shipit:
MKR WIFi 1010 :shipit:
PORTENTA :shipit:
ESP32 :shipit:
NICLA VISION :shipit:
OPTA :shipit:

@pennam pennam mentioned this pull request Jan 23, 2023
Merged
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Feb 13, 2023
@pennam
Remove OTA::setNetworkAdapter
ddcfdec 
Add iface parameter to OTA::onRequest
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Feb 14, 2023
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Feb 14, 2023
@github-actions
Copy link

github-actions bot commented Feb 14, 2023

Memory usage change @ ddcfdec

Board flash % RAM for global variables %
arduino:mbed_nano:nanorp2040connect 🔺 +5 - +33 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nicla:nicla_vision 💚 -240 - -176 -0.01 - -0.01 0 - 0 0.0 - 0.0
arduino:mbed_opta:opta 💚 -184 - -176 -0.02 - -0.02 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 💚 -240 - -176 -0.03 - -0.02 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 🔺 0 - +64 0.0 - +0.02 0 - 0 0.0 - 0.0
arduino:samd:mkrnb1500 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1300 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 ❔ -96 - +88 -0.04 - +0.03 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot ❔ -104 - +88 -0.04 - +0.03 0 - 0 0.0 - 0.0
esp32:esp32:esp32 🔺 +120 - +136 +0.01 - +0.01 0 - 0 0.0 - 0.0
esp8266:esp8266:huzzah 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/ArduinoIoTCloud-Advanced
flash		 % examples/ArduinoIoTCloud-Advanced
RAM for global variables		 % examples/ArduinoIoTCloud-Basic
flash		 % examples/ArduinoIoTCloud-Basic
RAM for global variables		 % examples/utility/ArduinoIoTCloud_Travis_CI
flash		 % examples/utility/ArduinoIoTCloud_Travis_CI
RAM for global variables		 % examples/utility/Provisioning
flash		 % examples/utility/Provisioning
RAM for global variables		 % examples/utility/SelfProvisioning
flash		 % examples/utility/SelfProvisioning
RAM for global variables		 %
arduino:mbed_nano:nanorp2040connect 33 0.0 0 0.0 33 0.0 0 0.0 33 0.0 0 0.0 5 0.0 0 0.0 5 0.0 0 0.0
arduino:mbed_nicla:nicla_vision -184 -0.01 0 0.0 -240 -0.01 0 0.0 -240 -0.01 0 0.0 -176 -0.01 0 0.0
arduino:mbed_opta:opta -176 -0.02 0 0.0 -184 -0.02 0 0.0 -184 -0.02 0 0.0 -176 -0.02 0 0.0
arduino:mbed_portenta:envie_m7 -176 -0.02 0 0.0 -240 -0.03 0 0.0 -176 -0.02 0 0.0 -176 -0.02 0 0.0
arduino:samd:mkr1000 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrgsm1400 64 0.02 0 0.0 56 0.02 0 0.0 56 0.02 0 0.0 0 0.0 0 0.0
arduino:samd:mkrnb1500 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwan1300 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwifi1010 88 0.03 0 0.0 80 0.03 0 0.0 80 0.03 0 0.0 -96 -0.04 0 0.0 -96 -0.04 0 0.0
arduino:samd:nano_33_iot 88 0.03 0 0.0 80 0.03 0 0.0 80 0.03 0 0.0 -104 -0.04 0 0.0 -104 -0.04 0 0.0
esp32:esp32:esp32 136 0.01 0 0.0 120 0.01 0 0.0 120 0.01 0 0.0
esp8266:esp8266:huzzah 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:mbed_nano:nanorp2040connect,33,0.0,0,0.0,33,0.0,0,0.0,33,0.0,0,0.0,5,0.0,0,0.0,5,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,-184,-0.01,0,0.0,-240,-0.01,0,0.0,-240,-0.01,0,0.0,-176,-0.01,0,0.0,,,,
arduino:mbed_opta:opta,-176,-0.02,0,0.0,-184,-0.02,0,0.0,-184,-0.02,0,0.0,-176,-0.02,0,0.0,,,,
arduino:mbed_portenta:envie_m7,-176,-0.02,0,0.0,-240,-0.03,0,0.0,-176,-0.02,0,0.0,-176,-0.02,0,0.0,,,,
arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrgsm1400,64,0.02,0,0.0,56,0.02,0,0.0,56,0.02,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrnb1500,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
arduino:samd:mkrwifi1010,88,0.03,0,0.0,80,0.03,0,0.0,80,0.03,0,0.0,-96,-0.04,0,0.0,-96,-0.04,0,0.0
arduino:samd:nano_33_iot,88,0.03,0,0.0,80,0.03,0,0.0,80,0.03,0,0.0,-104,-0.04,0,0.0,-104,-0.04,0,0.0
esp32:esp32:esp32,136,0.01,0,0.0,120,0.01,0,0.0,120,0.01,0,0.0,,,,,,,,
esp8266:esp8266:huzzah,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,

@arduino-libraries arduino-libraries deleted a comment from github-actions bot Feb 14, 2023
@pennam pennam marked this pull request as ready for review February 15, 2023 16:50
@pennam pennam requested a review from mirkokurt February 15, 2023 16:51
@pennam pennam merged commit 840f6bd into arduino-libraries:master Feb 28, 2023
@pennam pennam deleted the ota_move_code branch May 17, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mirkokurt mirkokurt mirkokurt approved these changes

Assignees

No one assigned

Labels

topic: code Related to content of the project itself type: enhancement Proposed improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pennam @mirkokurt @per1234