Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(functions): Set default functions region and add documentation - fix #1945 #1946

Merged
merged 2 commits into from
Nov 6, 2018

Conversation

paulstelzer
Copy link
Contributor

@paulstelzer paulstelzer commented Nov 5, 2018

Checklist

Description

Added a FunctionsDefaultRegion, so the user does not need to add a FunctionsRegionToken to his ngModule.

I also edited the documentation to use the FunctionsRegionToken.

IMPORTANT: I added FunctionsDefaultRegion as constant directly int the functions.ts . If you manage those constants anywhere also or inside the class, please change it!

Copy link
Member

@jamesdaniels jamesdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants