Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support region configuration via FunctionsRegionToken is a BREAKING CHANGE #1945

Closed
paulstelzer opened this issue Nov 4, 2018 · 1 comment

Comments

@paulstelzer
Copy link
Contributor

paulstelzer commented Nov 4, 2018

Today I wondered why my callable functions not working anymore. Then I saw that you tell "Support region configuration via FunctionsRegionToken". But if you not set it, the region is "null" and this region not exists.

So at the moment it is required to add { provide: FunctionsRegionToken, useValue: 'us-central1' }, to the providers section. From my point of view everyone who uses AngularFireFunctionsModule and callable functions, this is a BREAKING CHANGE

My feature request

it would be better, if no RegionToken is set, that the default value is 'us-central1'.

@alberthoekstra
Copy link

Sweet, this saved me some time.
I'm developing a Ionic3 app and was trying the new Functions module. Without the above solution the url started with 'https://null-' because the region info is missing.

This is also not documented here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants