fix(@angular/cli): ng doc doesn't open browser in Windows
#23166
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: review
In Windows, `process.exit` was being called prior of opening the browser which caused the browser never to open. Closes angular#23105
The webpack compiler was never closed which caused Webpack's shutdown hook https://github.com/angular/angular-cli/blob/c71832f3a9942aeb2c3dbd62f6edb4f0b8366465/packages/angular_devkit/build_angular/src/webpack/configs/styles.ts#L113-L114 to never be called and in turn caused the Sass workers never to be termined.
alan-agius4
force-pushed
the
open-docs-windows
branch
from
40466ee to
76e36cd
Compare
clydin
approved these changes
May 18, 2022
alan-agius4
added
action: merge
alan-agius4
added
target: rc
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
May 23, 2022
When running protractor, previously we didn't close the dev-server correctly when there was an error which caused the process to keep running following angular#23166
dgp1130
pushed a commit
that referenced
this pull request
May 23, 2022
When running protractor, previously we didn't close the dev-server correctly when there was an error which caused the process to keep running following #23166
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Windows,
process.exitwas being called prior of opening the browser which caused the browser never to open.Closes #23105