Skip to content

ng doc not working #23105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 15 tasks
doggy8088 opened this issue May 9, 2022 · 6 comments · Fixed by #23166
Closed
1 of 15 tasks

ng doc not working #23105

doggy8088 opened this issue May 9, 2022 · 6 comments · Fixed by #23166
Assignees
Labels
area: @angular/cli freq1: low Only reported by a handful of users who observe it rarely severity5: regression type: bug/fix
Milestone

Comments

@doggy8088
Copy link
Contributor

🐞 Bug report

Command (mark with an x)

  • new
  • build
  • serve
  • test
  • e2e
  • generate
  • add
  • update
  • lint
  • extract-i18n
  • run
  • config
  • help
  • version
  • doc

Is this a regression?

Yes, the previous version in which this bug was not present was: I don't know.

Description

The ng doc no longer open browser on Windows.

🔬 Minimal Reproduction

ng new demo1 --defaults
cd demo1
ng doc ActivatedRoute

🔥 Exception or Error

I expected to open browser and navigate to the angular.io site.

🌍 Your Environment



     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 13.3.5
Node: 16.13.0
Package Manager: npm 8.1.0
OS: win32 x64

Angular: 13.3.6
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1303.5
@angular-devkit/build-angular   13.3.5
@angular-devkit/core            13.3.5
@angular-devkit/schematics      13.3.5
@angular/cli                    13.3.5
@schematics/angular             13.3.5
rxjs                            7.5.5
typescript                      4.6.4

Anything else relevant?

N/A

@alan-agius4
Copy link
Collaborator

@gkalpak can you please check if you are able to replicate this?

I know you look into this before.

@alan-agius4 alan-agius4 added the needs: investigation Requires some digging to determine if action is needed label May 9, 2022
@gkalpak
Copy link
Member

gkalpak commented May 9, 2022

Yes, I can reproduce this. I'll investigate further.

@alan-agius4 alan-agius4 added type: bug/fix freq1: low Only reported by a handful of users who observe it rarely severity3: broken area: @angular/cli labels May 10, 2022
@ngbot ngbot bot modified the milestone: Backlog May 10, 2022
@alan-agius4 alan-agius4 removed the needs: investigation Requires some digging to determine if action is needed label May 10, 2022
@alan-agius4
Copy link
Collaborator

Thanks @gkalpak.

@alan-agius4
Copy link
Collaborator

@gkalpak, I can now take this as I have a Windows environment for testing.

@gkalpak
Copy link
Member

gkalpak commented May 18, 2022

Oh, cool 😃
It'll be a couple of days before I can get to this, so happy for you to take it over 🚀

alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue May 18, 2022
In Windows, `process.exit` was being called prior of opening the browaer which caused the browser never to open.

Closes angular#23105
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue May 18, 2022
In Windows, `process.exit` was being called prior of opening the browser which caused the browser never to open.

Closes angular#23105
clydin pushed a commit that referenced this issue May 18, 2022
In Windows, `process.exit` was being called prior of opening the browser which caused the browser never to open.

Closes #23105

(cherry picked from commit f99c08c)
clydin pushed a commit that referenced this issue May 18, 2022
In Windows, `process.exit` was being called prior of opening the browser which caused the browser never to open.

Closes #23105
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: @angular/cli freq1: low Only reported by a handful of users who observe it rarely severity5: regression type: bug/fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants