Skip to content

feat(@angular-devkit/build-angular): add support for port 0 when using protractor #13313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 8, 2019
Merged

feat(@angular-devkit/build-angular): add support for port 0 when using protractor #13313

merged 3 commits into from
Jan 8, 2019

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Dec 27, 2018

Fixes #13129

Depends on #13292 since checkPort was changed to return a Promise instead of Observable.

@alan-agius4 alan-agius4 added PR state: blocked target: major This PR is targeted for the next major release labels Dec 27, 2018
@clydin
Copy link
Member

clydin commented Dec 27, 2018

The actual port should really be pulled from the dev server. The OS knows how to handle zero, it would be more ideal/efficient to let it do the port determination.

@alan-agius4
Copy link
Collaborator Author

alan-agius4 commented Dec 27, 2018

@clydin, so why does the webserver has the logic to checkPort?
https://github.com/angular/angular-cli/blob/master/packages/angular_devkit/build_angular/src/dev-server/index.ts#L70

Also, the would change the return type of the builders since at the moment builders return BuildEvent.

@clydin
Copy link
Member

clydin commented Dec 27, 2018

We currently start the zero port search at a fixed number and changing that would be a breaking change. Ideally we should get rid of that logic in the next major and skip the port checking logic if zero is supplied. Since this is not burdened by the legacy behavior we can move directly to the ideal scenario.

@alan-agius4 alan-agius4 requested a review from clydin December 28, 2018 12:10
@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release and removed target: major This PR is targeted for the next major release labels Dec 28, 2018
@alexeagle alexeagle merged commit 030d5fa into angular:master Jan 8, 2019
@alan-agius4 alan-agius4 deleted the e2e_port_zero branch January 8, 2019 21:49
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'ng e2e --port 0' does not work on Windows
5 participants