refactor(@angular-devkit/build-angular): improve check port

[tiaguinho]

@hansl I have checked the usage of checkPort function, and the param basePort was never passed.
I also read the code of portfinder and saw that, when we set the port option, basePort will not be used.
Instead of that, I think set the highestPort to the same as the port we are looking for can improve the time to check if the port is opened.

What do you think?

[alan-agius4]

LGTM, thanks

[alan-agius4]

Ps: I think you need to remove Close 8595 from your commit message. As this doesn't fix anything per see.

[clydin]

Base port is used when zero is passed as the port. This shouldn’t be removed as it changes existing behavior.

[alan-agius4]

good catch @clydin.

[tiaguinho]

Make senses. But why someone will pass the port as zero @clydin ?

In this way of thinking, basePort is used as a parameter, which also can be passed as zero.
Will not make more sense remove this as a parameter and set the value directly to portfinder.basePort?

[alan-agius4]

Port 0 is a wildcard port, which tells the system to find a suitable available port.

This can be useful in CI’s, re the baseport, I am actually not sure why we don’t use the default. But while setting the base port is 0 is possible, it doesn’t make any sense to do so, and would probably result in an exception from port finder.

@clydin, would know more, re why not use the default.

[clydin]

The package really isn’t needed at all. If you are interested in a refactor, you could completely remove its usage.

If the supplied port is not zero, try to bind to the port and host. If it fails, throw the error. If it works, pass on the port.

[alan-agius4]

Thanks. See above.

[tiaguinho]

@alan-agius4 I change the checkPort observable to a promise.
All my changes are in separate commits, but if you want I can squash all into one.

Now that I have refactored the code, do you think this can close issue 8595?

[alan-agius4]

@tiaguinho, yeah this should solve #8595

[hansl]

One possible recursion. Otherwise looks good to me.

[alan-agius4]

Thanks, LGTM

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}