Skip to content

fix(@ngtools/webpack): report a warning when lazy route discovery is disabled #12559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2018
Merged

fix(@ngtools/webpack): report a warning when lazy route discovery is disabled #12559

merged 1 commit into from
Oct 23, 2018

Conversation

alan-agius4
Copy link
Collaborator

At the moment this will cause a runtime error instead. With this change the error is thrown during the build.

Closes #12238 and Closes #12025

@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Oct 11, 2018
@alan-agius4
Copy link
Collaborator Author

Umm seems like this breaks some current stuff, and it looks that we don't always have a bootstrap code.

@alan-agius4 alan-agius4 changed the title fix(@ngtools/webpack): build is not failing when no entry entry module is found fix(@ngtools/webpack): report a warning when lazy route discovery is disabled Oct 12, 2018
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…disabled

At the moment this will cause a runtime error instead. With this change a warning will be shown during the build.

Closes #12238 and Closes #12025
@kyliau kyliau merged commit f61ea6b into angular:master Oct 23, 2018
@alan-agius4 alan-agius4 deleted the fix_entry_module_error branch October 23, 2018 19:10
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
4 participants