-
Notifications
You must be signed in to change notification settings - Fork 12k
Angular compiler plugin not reporting some cases of not finding an entry module #12238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Can you setup a minimal repro please when this should error out? You can read here why this is needed. A good way to make a minimal repro is to create a new app via |
Done, please check this repo. If you go
|
Hi, I had a look at your reproduction however in your |
Sorry, I had forgot to push the changes, they are in the repository now. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…disabled At the moment this will cause a runtime error instead. With this change a warning will be shown during the build. Closes angular#12238 and Closes angular#12025
The three lines starting at
angular-cli/packages/ngtools/webpack/src/entry_resolver.ts
Line 155 in b403aa6
are bailing out without throwing the error at the end of
resolveEntryModuleFromMain
, which causes the build to proceed silently but generate bundles that actually fail at runtime. This should probably throw the same error.The text was updated successfully, but these errors were encountered: