Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mapDispatchToTarget to be an ES6 module #217

Merged
merged 1 commit into from
May 13, 2019
Merged

Allow mapDispatchToTarget to be an ES6 module #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/connector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export default function Connector(store) {

let finalMapStateToTarget = mapStateToTarget || defaultMapStateToTarget;

const finalMapDispatchToTarget = isPlainObject(mapDispatchToTarget) ?
const finalMapDispatchToTarget = isObject(mapDispatchToTarget) && !isFunction(mapDispatchToTarget) ?
wrapActionCreators(mapDispatchToTarget) :
mapDispatchToTarget || defaultMapDispatchToTarget;

Expand All @@ -25,7 +25,7 @@ export default function Connector(store) {
);

invariant(
isPlainObject(finalMapDispatchToTarget) || isFunction(finalMapDispatchToTarget),
isObject(finalMapDispatchToTarget) || isFunction(finalMapDispatchToTarget),
'mapDispatchToTarget must be a plain Object or a Function. Instead received %s.', finalMapDispatchToTarget
);

Expand Down
10 changes: 10 additions & 0 deletions test/components/connector.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,16 @@ describe('Connector', () => {
expect(receivedDispatch).toBe(store.dispatch);
});

it('Should allow ES6 modules', () => {
// The tests are run in Node, so we are unable to use actual ES6 modules. We get quite
// close by emulating it
class FakeModule {
prop() {}
};
const fakeModule = new FakeModule();
expect(() => connect(() => ({}), fakeModule)(targetObj)).toNotThrow();
});

it('Should provide state slice, bound actions and previous state slice to target (function)', () => {
const targetFunc = sinon.spy();

Expand Down