Allow mapDispatchToTarget to be an ES6 module #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelmertanen
changed the title
joelmertanen
force-pushed
the
allow-es6-objects
branch
2 times, most recently
from
7561577 to
50125e2
Compare
joelmertanen
force-pushed
the
allow-es6-objects
branch
from
50125e2 to
edef178
Compare
|
This is pretty cool, with this branch we were able to upgrade to webpack 4. I hope to get this merged so that we get rid of the fork. |
|
@villesau would you like to become a contributor/have access to the repo? Your branch from a few days ago was a big deal and if you understand what's going on here, I'd be happy to give you the ability to merge stuff in. |
|
@AntJanus sure, why not! I think I have fairly good understanding on what's going on in the repository since we've been going back and forth with a fork quite a long time now. This looks like easy going repository so I don't think it will take that much of my time. Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow connect to consume an ES6 module as the second parameter.
Motivation:
ES6 modules are more and more common in web development, and, from what I know, there are no reasons to not allow using them here. This patch is required for one of our internal projects to enable us to use the newest Webpack, so I hope that it will be found useful.
Questions:
Is the test enough to emulate the behaviour of an ES6 module in the NodeJS environment?