Skip to content

Improve linting to check for ES5 conformance (with exceptions to allow use of ES6 classes in certain modules) #5342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Nov 6, 2023
Merged

Improve linting to check for ES5 conformance (with exceptions to allow use of ES6 classes in certain modules) #5342

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
aff9e4f
Switch semistandard to standardx
diarmidmackenzie Jul 20, 2023
fc20747
Running with latest semistandard
diarmidmackenzie Jul 20, 2023
e2ae8c6
Tighten exceptions for use of `class` as tightly as possible
diarmidmackenzie Jul 22, 2023
a23b1c2
Alphabetize exceptions
diarmidmackenzie Jul 22, 2023
b864d25
Enforce computed-property-spacing rule
diarmidmackenzie Jul 22, 2023
880110d
Enforce "no-multiple-empty-lines" rule
diarmidmackenzie Jul 22, 2023
44059fd
Enforce "no-unused-expressions" rule
diarmidmackenzie Jul 22, 2023
e9e0490
Enforce 'no-use-before-define' rule
diarmidmackenzie Jul 22, 2023
8bcfd05
Enforce 'object-curly-newline' rule
diarmidmackenzie Jul 22, 2023
ab08cff
Enforce 'quotes' rule
diarmidmackenzie Jul 22, 2023
c6e4c21
Enforce 'spaced-comment' rule
diarmidmackenzie Jul 22, 2023
ade9e3a
Enforce 'valid-typeof' rule
diarmidmackenzie Jul 22, 2023
0659ad1
Add comments explaining unenforced rules
diarmidmackenzie Jul 22, 2023
093e8e0
Apply 'array-bracket-spacing' rule
diarmidmackenzie Jul 22, 2023
2663bb3
Final comments on unused linting rules from semistandard v17
diarmidmackenzie Jul 22, 2023
41251db
More comments to explain config
diarmidmackenzie Jul 22, 2023
b9d3133
PR review feedback
diarmidmackenzie Nov 5, 2023
6217b74
PR feedback
diarmidmackenzie Nov 5, 2023
bdda584
Correct merge issue from rebase; linting issues.
diarmidmackenzie Nov 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Enforce "no-unused-expressions" rule
  • Loading branch information
@diarmidmackenzie
diarmidmackenzie committed Nov 5, 2023
commit 44059fd4daff9d64547298b1fab42e01bac679cf
1 change: 0 additions & 1 deletion .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
"no-mixed-operators": "off",
"no-multi-spaces": "off",
"no-unreachable-loop": "off",
"no-unused-expressions": "off",
"no-unused-vars": "off",
"no-use-before-define": "off",
"no-useless-return": "off",
Expand Down
2 changes: 1 addition & 1 deletion examples/showcase/ui/info-panel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ AFRAME.registerComponent('info-panel', {
var buttonEls = document.querySelectorAll('.menu-button');
var fadeBackgroundEl = this.fadeBackgroundEl = document.querySelector('#fadeBackground');

this.movieImageEl;
this.movieImageEl = null;
this.movieTitleEl = document.querySelector('#movieTitle');
this.movieDescriptionEl = document.querySelector('#movieDescription');

Expand Down