Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add comments explaining unenforced rules
  • Loading branch information
diarmidmackenzie committed Nov 5, 2023
commit 0659ad1ce17a906c2a184902dad9c4978516353a
36 changes: 25 additions & 11 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,22 +4,36 @@
"ecmaVersion": 12
},
"rules": {
"array-bracket-spacing": "off",
"array-callback-return": "off",
/* These rules are incompatible with ES5 */
"no-var": "off",
"object-shorthand": "off",
"prefer-const": "off",
"prefer-regex-literals": "off",


/* These rules are compatible with ES5
However they involve non-trivial code changes
Therefore need more careful review before adopting */
"no-mixed-operators": "off",
"no-unreachable-loop": "off",
"no-useless-return": "off",
"prefer-promise-reject-errors": "off",


/* These rules are compatible with ES5
However they involve large-scale changes to the codebase, so
careful co-ordination is needed in adopting the rule to avoid
creating merge issues for other PRs*/
"dot-notation": "off",
"indent": "off",
"no-mixed-operators": "off",
"no-multi-spaces": "off",
"no-unreachable-loop": "off",
"no-unused-vars": "off",
"no-useless-return": "off",
"no-var": "off",
"object-curly-spacing": "off",
"object-shorthand": "off",
"prefer-const": "off",
"prefer-promise-reject-errors": "off",
"prefer-regex-literals": "off",
"quote-props": "off"
"quote-props": "off",

/* These rules still to be reviewed */
"array-bracket-spacing": "off",
"array-callback-return": "off"
},
"overrides": [
{
Expand Down