Skip to content

Updated block_device type annotation #7755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Updated block_device type annotation #7755

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e630a5
Updated block_device type annotation
isacben Mar 19, 2023
d9d27a3
Fix signature of `mkfs()`
dhalbert Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions shared-bindings/storage/__init__.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ STATIC const mp_rom_map_elem_t storage_module_globals_table[] = {
{ MP_ROM_QSTR(MP_QSTR_enable_usb_drive), MP_ROM_PTR(&storage_enable_usb_drive_obj) },

//| class VfsFat:
//| def __init__(self, block_device: str) -> None:
//| def __init__(self, block_device: BlockDevice) -> None:
//| """Create a new VfsFat filesystem around the given block device.
//|
//| :param block_device: Block device the the filesystem lives on"""
Expand All @@ -267,7 +267,7 @@ STATIC const mp_rom_map_elem_t storage_module_globals_table[] = {
//| ...
//|
//| @staticmethod
//| def mkfs(self) -> None:
//| def mkfs(block_device: BlockDevice) -> None:
//| """Format the block device, deleting any data that may have been there.
//|
//| **Limitations**: On SAMD21 builds, `mkfs()` will raise ``OSError(22)`` when
Expand Down