Updated block_device type annotation #7755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
requested changes
Mar 21, 2023
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Making one change and re-running: I merged your addition to the circuitpython_typing library.
dhalbert
approved these changes
Mar 21, 2023
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Thanks very much! All set.
Author
|
Than you very much, Dan!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
With this PR I am trying to solve #7741 (Define abstract "block device" type for use in VfsFat and elsewhere)
Depends on:
adafruit/Adafruit_CircuitPython_Typing#30
I opened the PR above in the CircuitPython_Typing repository to add the abstract class.
Please let me know if I have all the pieces or if I am missing something.
Thanks!