Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix horizontal flip in camera example #9

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Fix horizontal flip in camera example #9

merged 2 commits into from
Dec 19, 2023

Conversation

caternuson
Copy link
Contributor

@caternuson caternuson commented Dec 19, 2023 •
edited
Loading

Simple fix for #7.

EDIT - oops wrong issue number. fixed.

@dhalbert dhalbert linked an issue Dec 19, 2023 that may be closed by this pull request
horizontally flipped preview/image #7
Closed
@dhalbert dhalbert requested a review from jepler December 19, 2023 20:28
@jepler
Copy link
Contributor

jepler commented Dec 19, 2023

I only wonder if we shouldn't set it in the constructor instead so that it fixes all demos.

@dhalbert
Copy link
Contributor

dhalbert commented Dec 19, 2023 •
edited
Loading

I only wonder if we shouldn't set it in the constructor instead so that it fixes all demos.

That is a better idea. I wrongly assumed that was what this does.

jepler
jepler approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can merge it this way if you want but as I said in comment form a moment ago I wonder if it wouldn't be better to do it in the camera class so all demos benefit from getting the image orientation right.

@caternuson
Copy link
Contributor Author

Changed fix to be in init instead of user code.

@dhalbert dhalbert requested a review from jepler December 19, 2023 20:39
jepler
jepler approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for switching it

@jepler jepler merged commit 17cae31 into adafruit:main Dec 19, 2023
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 20, 2023
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@2959bae)
4e6ee8e 
Updating https://github.com/adafruit/Adafruit_CircuitPython_PyCamera to 0.0.6 from 0.0.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyCamera#12 from adafruit/speaker-mute
  > Merge pull request adafruit/Adafruit_CircuitPython_PyCamera#9 from caternuson/iss1
  > Merge pull request adafruit/Adafruit_CircuitPython_PyCamera#8 from brentru/update-requirements-txt

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepler jepler jepler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

horizontally flipped preview/image
3 participants
@caternuson @jepler @dhalbert