Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependencies to requirements.txt #8

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

brentru
Copy link
Member

@brentru brentru commented Dec 19, 2023

After using circup to install this library, there are still missing dependencies required to run the camera example. This pull request adds additional libraries to requirements.txt so we can include those for folks using circup and/or the bundler.

@brentru brentru requested a review from jepler December 19, 2023 17:29
@brentru
Copy link
Member Author

brentru commented Dec 19, 2023

cc: @dhalbert as this may close an issue you mentioned you opened in discord

Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These requirements are all referenced in __init__.py, not just the examples, so this makes sense.

@dhalbert dhalbert merged commit b54608f into adafruit:main Dec 19, 2023
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 20, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_PyCamera to 0.0.6 from 0.0.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyCamera#12 from adafruit/speaker-mute
  > Merge pull request adafruit/Adafruit_CircuitPython_PyCamera#9 from caternuson/iss1
  > Merge pull request adafruit/Adafruit_CircuitPython_PyCamera#8 from brentru/update-requirements-txt

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants