-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timelapse mode #22
Timelapse mode #22
Conversation
👋 Thanks for this pull request! Unfortunately, it looks like the automated continuous integration (CI) test(s) failed. These can be tricky to fix so we've written a guide on how to fix them locally. It has pages about running pre-commit locally and another about building the docs locally with sphinx. Thanks for contributing to CircuitPython! If you have more questions, feel free to join the Adafruit Discord and post in #circuitpython-dev. |
@ladyada I tested this, it's working great! One feature request: could we have option to lock and auto settings such as exposure/white balance to reduce strobing during playback of frames? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge once the linter is happy. LMK if you want me to do that bit.
…t can be frozen during timelapse
@jedgarpark dunzo - please check latest commit code/library for 'frozen' settings |
examples/camera/code.py
Outdated
pycam._timelapse_rate_label.text = pycam._timelapse_rate_label.text | ||
pycam._timelapse_submode_label.text = pycam._timelapse_submode_label.text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were these re-assignments of the label text really needed? I'll try testing without it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes because otherwise display refresh doesnt pick up the labels after the screen has been blitted manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, will add a comment to that effect
There's some minor flickering on the screen when the new labels are in use but nothing that makes me want to hold this back |
yeah this is something i could fix but was like, not willing to put in the extra time right now :D |
@ladyada just got back from trip, tested timelapse, the new locked settings are great, no more flicker! |
Updating https://github.com/adafruit/Adafruit_CircuitPython_DS18X20 to 1.4.0 from 1.3.19: > Merge pull request adafruit/Adafruit_CircuitPython_DS18X20#29 from ilikecake/main Updating https://github.com/adafruit/Adafruit_CircuitPython_FocalTouch to 1.5.2 from 1.5.1: > Merge pull request adafruit/Adafruit_CircuitPython_FocalTouch#32 from ilikecake/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.16.2 from 1.16.1: > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#129 from scirelli/issue_128 Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Button to 1.9.1 from 1.9.0: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Button#44 from DJDevon3/DJDevon3_Working_Branch Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 2.1.0 from 2.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#92 from FoamyGuy/gridlayout_cell_contains Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 4.5.3 from 4.5.1: > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#79 from michalpokusa/cpython-fix > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#78 from tedder/ted/cpython_port5k Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.9.0 from 2.8.0: > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#116 from tylerwinfield/main Updating https://github.com/adafruit/Adafruit_CircuitPython_PyCamera to 0.0.9 from 0.0.8: > Merge pull request adafruit/Adafruit_CircuitPython_PyCamera#23 from adafruit/blendmode > Merge pull request adafruit/Adafruit_CircuitPython_PyCamera#22 from adafruit/timelapse > Merge pull request adafruit/Adafruit_CircuitPython_PyCamera#21 from adafruit/fix_rl Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 2.0.5 from 2.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#152 from justmobilize/fix-null-headers Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
@jedgarpark this is a new timelapsing mode with sub-modes use OK to turn on / off timelapse, and SEL button to change power mode (backlight/preview)