Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gridlayout cell contains #92

Merged
merged 6 commits into from
Jan 29, 2024
Merged

Conversation

FoamyGuy
Copy link
Contributor

This PR adds a few main things:

  • new properties for width and height that turned out to be convenient for the real functionality I wanted to add
  • enhancement to get_cell() to allow it to correctly locate multi-spanned cells
  • new function which_cell_contains() which takes a pixel x,y location and returns the cell coordinates of the cell that contains that pixel location. Helpful for use with touchscreens.
  • added terminalio to doc mock list to get docs building successfully

@FoamyGuy
Copy link
Contributor Author

The latest commit to this branch fixes an issue that resulted from the divider line objects being erroneously removed from their containing group twice which raised an exception.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@FoamyGuy FoamyGuy merged commit 19fdbc4 into adafruit:main Jan 29, 2024
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 6, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_DS18X20 to 1.4.0 from 1.3.19:
  > Merge pull request adafruit/Adafruit_CircuitPython_DS18X20#29 from ilikecake/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_FocalTouch to 1.5.2 from 1.5.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_FocalTouch#32 from ilikecake/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.16.2 from 1.16.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#129 from scirelli/issue_128

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Button to 1.9.1 from 1.9.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Button#44 from DJDevon3/DJDevon3_Working_Branch

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 2.1.0 from 2.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#92 from FoamyGuy/gridlayout_cell_contains

Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 4.5.3 from 4.5.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#79 from michalpokusa/cpython-fix
  > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#78 from tedder/ted/cpython_port5k

Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.9.0 from 2.8.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#116 from tylerwinfield/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyCamera to 0.0.9 from 0.0.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyCamera#23 from adafruit/blendmode
  > Merge pull request adafruit/Adafruit_CircuitPython_PyCamera#22 from adafruit/timelapse
  > Merge pull request adafruit/Adafruit_CircuitPython_PyCamera#21 from adafruit/fix_rl

Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 2.0.5 from 2.0.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#152 from justmobilize/fix-null-headers

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants