Simplify socket exceptions #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justmobilize
force-pushed
the
simplify-socket-exceptions
branch
from
75bb35b to
4f0012c
Compare
justmobilize
force-pushed
the
simplify-socket-exceptions
branch
from
4f0012c to
3e5d4ab
Compare
|
Looks fine to me. Will leave it up to Brent though since he uses this code afaik. |
brentru
requested changes
Feb 14, 2024
brentru
approved these changes
Feb 14, 2024
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 21, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_IRRemote to 4.1.19 from 4.1.18: > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#67 from Kry-Vosa/main Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.12.4 from 3.12.3: > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#119 from reza-n/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.16.3 from 1.16.2: > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#126 from logandgsmith/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_asyncio to 1.3.1 from 1.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_asyncio#64 from kbsriram/main Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 6.1.0 from 6.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_HID#124 from pythonmcpi/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_IterTools to 2.0.8 from 2.0.7: > Merge pull request adafruit/Adafruit_CircuitPython_IterTools#20 from kbsriram/main Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.5.9 from 7.5.8: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#203 from justmobilize/simplify-socket-exceptions Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to simplify socket exceptions, so the move to ConnectionManager is smother.
Currently when getting a socket, an
OSErroris not treated as aTemporaryErrorand thus the retry is delayed. As far as I can tell, there is no benefit to delaying the next try here and it will causeConnectionManagerto be overly complex.This treats
OSErrorlike any other error, and thus no custom handling will be needed inConnectionManager.If there is something I am missing, please let me know.