Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First batch of type annotations. #20

Merged
merged 1 commit into from
Feb 20, 2024
Merged

First batch of type annotations. #20

merged 1 commit into from
Feb 20, 2024

Conversation

kbsriram
Copy link
Contributor

This adds a subset of type annotations for #12 This PR just adds "simpler" annotations that are hopefully easier to review in one shot, with follow-up but smaller PRs for some of the trickier items.

These are the remaining items in adafruit_itertools if this PR is merged.

$ mypy --disallow-untyped-defs adafruit_itertools/__init__.py 
adafruit_itertools/__init__.py:56: error: Function is missing a type annotation  [no-untyped-def]
adafruit_itertools/__init__.py:203: error: Function is missing a type annotation  [no-untyped-def]
adafruit_itertools/__init__.py:291: error: Function is missing a type annotation  [no-untyped-def]
adafruit_itertools/__init__.py:296: error: Function is missing a type annotation  [no-untyped-def]
adafruit_itertools/__init__.py:299: error: Function is missing a return type annotation  [no-untyped-def]
adafruit_itertools/__init__.py:307: error: Function is missing a type annotation  [no-untyped-def]
adafruit_itertools/__init__.py:317: error: Function is missing a type annotation  [no-untyped-def]
Found 7 errors in 1 file (checked 1 source file)

I'll send follow-up PRs for this and the adafruit_itertools_extra module if this PR seems on the right track.

This adds a subset of type annotations for adafruit#12
This PR just adds "simpler" annotations that are hopefully easier
to review in one shot, with follow-up but smaller PRs for some of
the trickier items.
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for getting this started @kbsriram!

Feel free to continue on with the others you mentioned.

@FoamyGuy FoamyGuy merged commit 7a6f049 into adafruit:main Feb 20, 2024
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 21, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_IRRemote to 4.1.19 from 4.1.18:
  > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#67 from Kry-Vosa/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.12.4 from 3.12.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#119 from reza-n/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.16.3 from 1.16.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#126 from logandgsmith/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_asyncio to 1.3.1 from 1.3.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_asyncio#64 from kbsriram/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 6.1.0 from 6.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_HID#124 from pythonmcpi/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_IterTools to 2.0.8 from 2.0.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_IterTools#20 from kbsriram/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.5.9 from 7.5.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#203 from justmobilize/simplify-socket-exceptions

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants