Enhance transmit in GenericTransmit to optionally allow sending bits and repeating commands #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 9, 2021 18:24
transmit now takes some keyword args to control additional repeats, delays for those repeats and nbits to allow a number of bits less than those in data bytes (useful for Sony codes). debug option added to constructor to control previously commented out printing of durations.
kevinjwalters
changed the title
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 15, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_BME280 to 2.6.1 from 2.6.0: > Merge pull request adafruit/Adafruit_CircuitPython_BME280#46 from jposada202020/improving_docs Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 5.3.0 from 5.2.6: > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#78 from ViennaMike/axis_remap Updating https://github.com/adafruit/Adafruit_CircuitPython_IRRemote to 4.0.6 from 4.0.5: > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#46 from kevinjwalters/tx-var-bits > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_SHTC3 to 1.0.6 from 1.0.5: > Merge pull request adafruit/Adafruit_CircuitPython_SHTC3#7 from jposada202020/improving_docs > "Increase duplicate code check threshold " > Merge pull request adafruit/Adafruit_CircuitPython_SHTC3#6 from FoamyGuy/pylintrc_and_versions Updating https://github.com/adafruit/Adafruit_CircuitPython_MIDI to 1.4.0 from 1.3.5: > Added copyright information > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#27 from gamblor21/add_control_values Updating https://github.com/adafruit/Adafruit_CircuitPython_SimpleMath to 2.0.0 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_SimpleMath#2 from lesamouraipourpre/unconstrained-map-range > Added tests check to pre commit config > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_Colorsys
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
nbitstotransmit()to allow it to send less bits than in thedatabytes. This is essential for the 20bit codes used by Sony (#44). Also addedrepeatanddelayto allow a command to be repeated a few times - seems to be common practice in many IR systems to increase reliability of the (simplex) transmission.Added a
debugarg toGenericTransmitconstructor to control the previously commented out printing ofdurationsinsidetransmit()as it looked useful. Passing atrailvalue ofNonenow disables it - this is required for Sony codes.Tested with https://github.com/kevinjwalters/circuitpython-examples/blob/master/cpx/cpx-ir-shutter-remote.py