Skip to content

fixed the merge implementation in MergeSort #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2021

Conversation

guyariely
Copy link

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@guyariely
Copy link
Author

This is an update on #579.

@pomkarnath98
Copy link
Member

Thanks for your contribution @guyariely.
But even after #579, you didn't rectify your mistakes. Once again mentioning, try to use let and const instead of using var and commit.
Otherwise, the code is working fine.

@pomkarnath98 pomkarnath98 added the changes required This pull request needs changes label May 22, 2021
@guyariely
Copy link
Author

@pomkarnath98 there are no var in my commit ... it only includes let and const.

@pomkarnath98
Copy link
Member

It's not in your commit but in your file.

image

@guyariely
Copy link
Author

I updated the rest of the file to only include let / const.

@pomkarnath98 pomkarnath98 merged commit d220eb9 into TheAlgorithms:master May 22, 2021
@raklaptudirm raklaptudirm removed the changes required This pull request needs changes label May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants