fixed the merge implementation in MergeSort #579
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 3 alerts when merging 39a1131 into fb9ad3b - view on LGTM.com new alerts:
|
ruppysuppy
requested changes
May 5, 2021
| function merge (list1, list2) { | ||
| var results = [] | ||
| function merge(list1, list2) { | ||
| results = Array(list1.length + list2.length); |
There was a problem hiding this comment.
- results = Array(list1.length + list2.length);
+ const results = Array(list1.length + list2.length);Make sure to use standard to format the file as well
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to achieve n*log(n) time complexity, MergeSort relies on the merge function running in linear time.
Currently it runs on n^2 because of the use of the shift function.