Skip to content

add labels field to PullRequest #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 24, 2022
Merged

add labels field to PullRequest #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
165795d
add labels field
KristofferC Aug 19, 2018
5383102
Encode PR labels as Label objects.
maleadt Nov 24, 2022
2efc8d6
Add a test.
maleadt Nov 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/GitHub.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,11 +178,11 @@ export # secrets.jl

# include -------

include("issues/labels.jl")
include("issues/pull_requests.jl")
include("issues/issues.jl")
include("issues/comments.jl")
include("issues/reviews.jl")
include("issues/labels.jl")

# export -------

Expand Down
28 changes: 28 additions & 0 deletions src/issues/issues.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,3 +53,31 @@ end
result = gh_patch_json(api, "/repos/$(name(repo))/issues/$(name(issue))"; options...)
return Issue(result)
end

# labels #
#--------#

@api_default function labels(api::GitHubAPI, repo, issue; options...)
result = gh_get_json(api, "/repos/$(name(repo))/issues/$(name(issue))/labels"; options...)
return Label.(result)
end

@api_default function add_labels(api::GitHubAPI, repo, issue, labels; options...)
result = gh_post_json(api, "/repos/$(name(repo))/issues/$(name(issue))/labels";
params=Dict("labels" => name.(labels)), options...)
return Label.(result)
end

@api_default function set_labels(api::GitHubAPI, repo, issue, labels; options...)
result = gh_put_json(api, "/repos/$(name(repo))/issues/$(name(issue))/labels";
params=Dict("labels" => name.(labels)), options...)
return Label.(result)
end

@api_default function remove_all_labels(api::GitHubAPI, repo, issue; options...)
return gh_delete(api, "/repos/$(name(repo))/issues/$(name(issue))/labels"; options...)
end

@api_default function remove_label(api::GitHubAPI, repo, issue, label; options...)
return gh_delete(api, "/repos/$(name(repo))/issues/$(name(issue))/labels/$(name(label))"; options...)
end
25 changes: 0 additions & 25 deletions src/issues/labels.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,28 +11,3 @@ end
namefield(label::Label) = label.name

Label(name::AbstractString) = Label(Dict("name" => name))

@api_default function labels(api::GitHubAPI, repo, issue; options...)
result = gh_get_json(api, "/repos/$(name(repo))/issues/$(name(issue))/labels"; options...)
return Label.(result)
end

@api_default function add_labels(api::GitHubAPI, repo, issue, labels; options...)
result = gh_post_json(api, "/repos/$(name(repo))/issues/$(name(issue))/labels";
params=Dict("labels" => name.(labels)), options...)
return Label.(result)
end

@api_default function set_labels(api::GitHubAPI, repo, issue, labels; options...)
result = gh_put_json(api, "/repos/$(name(repo))/issues/$(name(issue))/labels";
params=Dict("labels" => name.(labels)), options...)
return Label.(result)
end

@api_default function remove_all_labels(api::GitHubAPI, repo, issue; options...)
return gh_delete(api, "/repos/$(name(repo))/issues/$(name(issue))/labels"; options...)
end

@api_default function remove_label(api::GitHubAPI, repo, issue, label; options...)
return gh_delete(api, "/repos/$(name(repo))/issues/$(name(issue))/labels/$(name(label))"; options...)
end
1 change: 1 addition & 0 deletions src/issues/pull_requests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
mergeable::Union{Bool, Nothing}
merged::Union{Bool, Nothing}
locked::Union{Bool, Nothing}
labels::Union{Vector{Label}, Nothing}
end

PullRequest(number::Real) = PullRequest(Dict("number" => number))
Expand Down
3 changes: 2 additions & 1 deletion test/ghtype_tests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,8 @@ end
nothing,
nothing,
nothing,
pr_json["locked"]
pr_json["locked"],
nothing
)

@test PullRequest(pr_json) == pr_result
Expand Down
6 changes: 5 additions & 1 deletion test/read_only_api_tests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,11 @@ end
state_param = Dict("state" => "all")

# test GitHub.pull_request, GitHub.pull_requests
@test pull_request(ghjl, 37; auth = auth).title == "Fix dep warnings"
let pr = pull_request(ghjl, 37; auth = auth)
@test pr.title == "Fix dep warnings"
@test length(pr.labels) == 1
@test pr.labels[1].name == "enhancement"
end
@test hasghobj(37, first(pull_requests(ghjl; auth = auth, params = state_param)))

# test GitHub.issue, GitHub.issues
Expand Down