Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add labels field to PullRequest #115

Merged
merged 3 commits into from
Nov 24, 2022
Merged

add labels field to PullRequest #115

merged 3 commits into from
Nov 24, 2022

Conversation

KristofferC
Copy link
Collaborator

No description provided.

@KristofferC
Copy link
Collaborator Author

A question here @ararslan, @Keno, @jrevels.

What is the thought regarding things like a Vector of labels that exist here? Should there be a GitHub object called Label with the pertinent fields, and we then have a Vector{Label} or should we just do like this and keep it like a Dict?.

@Keno
Copy link
Contributor

Keno commented Aug 19, 2018

Either way is generally fine with me. I don't usually build out too much it in objects unless there's a good reason to.

@ararslan
Copy link
Member

I'm fairly indifferent. Do whatever feels right in your heart.

@Keno
Copy link
Contributor

Keno commented Aug 26, 2018

See test failures. Other than that, this is fine.

@maleadt
Copy link
Collaborator

maleadt commented Nov 24, 2022

Rebased, and made this use the Label object that's since been introduced.

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2022

Codecov Report

Merging #115 (2efc8d6) into master (809994e) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #115   +/-   ##
=======================================
  Coverage   56.22%   56.22%           
=======================================
  Files          36       36           
  Lines         843      843           
=======================================
  Hits          474      474           
  Misses        369      369           
Impacted Files Coverage Δ
src/GitHub.jl 100.00% <ø> (ø)
src/issues/issues.jl 32.14% <0.00%> (-27.86%) ⬇️
src/issues/labels.jl 100.00% <ø> (+81.25%) ⬆️
src/issues/pull_requests.jl 44.44% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maleadt maleadt merged commit 9cac3b9 into master Nov 24, 2022
@maleadt maleadt deleted the labels branch November 24, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants