feat(example): add nested complex views #1111

abdelhamid-f-nasser · 2024-01-28T14:07:45Z

Description of the change

Allows testing using complex nested views

Type of change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: MOB-13737

Checklists

Development

Lint rules pass locally
The code changed/added as part of this pull request has been covered with tests

Code review

This pull request has a descriptive title and information useful to a reviewer
Issue from task tracker has a link to this pull request

Allows testing using complex nested views

mnoseir · 2024-01-28T14:18:58Z

Coverage Report

Label	Coverage	Status
JavaScript	96.2%	✅
Android	49.2%	✅
iOS	40.7%	✅

Generated by 🚫 dangerJS against 56fb01e

a7medev

Good job @abdelhamid-f-nasser! 👏🏼
Let's also remove the textInput style in styles in BasicComponentsScreen.tsx since we're now using the InputField component rather than the plain TextInput component and they're not needed.

We might also combine the formControl style with the button style directly without the need for separation and StyleSheet.flatten since they're now only used by buttons, and remove the formControlStyles object.

a7medev · 2024-01-28T15:00:14Z

examples/default/src/components/InputField.tsx

+
+import { KeyboardTypeOptions, StyleSheet, TextInput } from 'react-native';
+
+interface InputFieldProps extends PropsWithChildren {


I think there's no need to extend PropsWithChildren here since InputField won't have any children anyway.

a7medev · 2024-01-28T15:01:02Z

examples/default/src/components/NestedView.tsx

+import { Text } from 'native-base';
+import { StyleSheet, View } from 'react-native';
+
+interface NestedViewProps extends PropsWithChildren {


Same as InputField, I don't think we need PropsWithChildren here.

a7medev · 2024-01-28T15:02:06Z

examples/default/src/navigation/HomeStack.tsx

+      <HomeStack.Screen
+        name="ComplexViews"
+        component={ComplexViewsScreen}
+        options={{ title: 'Basic Components' }}


I think this screen title should be something like "Complex Views" instead of "Basic Components"

Copy Paste typo 😅.

abdelhamid-f-nasser · 2024-01-28T16:32:32Z

Thanks you for the thorough review @a7medev 👍 🥇. Please recheck 🙏 .

abdelhamid-f-nasser · 2024-01-28T20:43:20Z

@a7medev I've refactored the InputField to accept passing ref using forwardRef to enable using it with Instabug.addPrivateView.

Also let's merge this in order to use this in the #1109 As it's a requirement for testing.

a7medev

LGTM, good job @abdelhamid-f-nasser! 👏🏼

Jira ID: MOB-13737

* feat(example): add nested complex views (#1111) Jira ID: MOB-13737 * fix hybrid mode code push version init (#1108) * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * ci: migrate macos machines to m1 (#1114) * feat: support identify user by id (#1115) Jira ID: MOB-13746 * ci: replace d11 cluster url in UploadSourcemaps (#1122) * fix(android): resolve private views through UI manager directly (#1121) * feat: support switching to native network interception (#1120) * feat(example): Add more sdk crashes buttons * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * feat(example): Add more sdk crashes buttons * fix dev merge issue * feat_add_crash_buttons * feat_add_crash_buttons * feat_add_crash_buttons * fix: PlatformListTile typo name --------- Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com> Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com> Co-authored-by: AbdElHamid Nasser <anasser@instabug.com>

* feat_add_setNDKCrashesEnabled * fix android_testing issue * rename_test_cases * fix_pr_comments * feat/add-ndk-demo-crash-buttons * chore: add ChangeLog changes * Update CHANGELOG.md Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com> * feat: add more crash scenarios to example app (#1131) * feat(example): add nested complex views (#1111) Jira ID: MOB-13737 * fix hybrid mode code push version init (#1108) * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * ci: migrate macos machines to m1 (#1114) * feat: support identify user by id (#1115) Jira ID: MOB-13746 * ci: replace d11 cluster url in UploadSourcemaps (#1122) * fix(android): resolve private views through UI manager directly (#1121) * feat: support switching to native network interception (#1120) * feat(example): Add more sdk crashes buttons * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * feat(example): Add more sdk crashes buttons * fix dev merge issue * feat_add_crash_buttons * feat_add_crash_buttons * feat_add_crash_buttons * fix: PlatformListTile typo name --------- Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com> Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com> Co-authored-by: AbdElHamid Nasser <anasser@instabug.com> * feat_add_setNDKCrashesEnabled * fix android_testing issue * rename_test_cases * fix_pr_comments * feat/add-ndk-demo-crash-buttons * chore: add ChangeLog changes * Update CHANGELOG.md Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com> * fix:lint issue * fix: CHANGELOG typo issue Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com> --------- Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com> Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com> Co-authored-by: AbdElHamid Nasser <anasser@instabug.com>

Jira ID: MOB-13737

* feat(example): add nested complex views (#1111) Jira ID: MOB-13737 * fix hybrid mode code push version init (#1108) * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * ci: migrate macos machines to m1 (#1114) * feat: support identify user by id (#1115) Jira ID: MOB-13746 * ci: replace d11 cluster url in UploadSourcemaps (#1122) * fix(android): resolve private views through UI manager directly (#1121) * feat: support switching to native network interception (#1120) * feat(example): Add more sdk crashes buttons * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * feat(example): Add more sdk crashes buttons * fix dev merge issue * feat_add_crash_buttons * feat_add_crash_buttons * feat_add_crash_buttons * fix: PlatformListTile typo name --------- Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com> Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com> Co-authored-by: AbdElHamid Nasser <anasser@instabug.com>

* feat_add_setNDKCrashesEnabled * fix android_testing issue * rename_test_cases * fix_pr_comments * feat/add-ndk-demo-crash-buttons * chore: add ChangeLog changes * Update CHANGELOG.md Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com> * feat: add more crash scenarios to example app (#1131) * feat(example): add nested complex views (#1111) Jira ID: MOB-13737 * fix hybrid mode code push version init (#1108) * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * ci: migrate macos machines to m1 (#1114) * feat: support identify user by id (#1115) Jira ID: MOB-13746 * ci: replace d11 cluster url in UploadSourcemaps (#1122) * fix(android): resolve private views through UI manager directly (#1121) * feat: support switching to native network interception (#1120) * feat(example): Add more sdk crashes buttons * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * feat(example): Add more sdk crashes buttons * fix dev merge issue * feat_add_crash_buttons * feat_add_crash_buttons * feat_add_crash_buttons * fix: PlatformListTile typo name --------- Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com> Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com> Co-authored-by: AbdElHamid Nasser <anasser@instabug.com> * feat_add_setNDKCrashesEnabled * fix android_testing issue * rename_test_cases * fix_pr_comments * feat/add-ndk-demo-crash-buttons * chore: add ChangeLog changes * Update CHANGELOG.md Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com> * fix:lint issue * fix: CHANGELOG typo issue Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com> --------- Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com> Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com> Co-authored-by: AbdElHamid Nasser <anasser@instabug.com>

Jira ID: MOB-13737

* feat(example): add nested complex views (#1111) Jira ID: MOB-13737 * fix hybrid mode code push version init (#1108) * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * ci: migrate macos machines to m1 (#1114) * feat: support identify user by id (#1115) Jira ID: MOB-13746 * ci: replace d11 cluster url in UploadSourcemaps (#1122) * fix(android): resolve private views through UI manager directly (#1121) * feat: support switching to native network interception (#1120) * feat(example): Add more sdk crashes buttons * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * feat(example): Add more sdk crashes buttons * fix dev merge issue * feat_add_crash_buttons * feat_add_crash_buttons * feat_add_crash_buttons * fix: PlatformListTile typo name --------- Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com> Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com> Co-authored-by: AbdElHamid Nasser <anasser@instabug.com>

* feat_add_setNDKCrashesEnabled * fix android_testing issue * rename_test_cases * fix_pr_comments * feat/add-ndk-demo-crash-buttons * chore: add ChangeLog changes * Update CHANGELOG.md Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com> * feat: add more crash scenarios to example app (#1131) * feat(example): add nested complex views (#1111) Jira ID: MOB-13737 * fix hybrid mode code push version init (#1108) * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * ci: migrate macos machines to m1 (#1114) * feat: support identify user by id (#1115) Jira ID: MOB-13746 * ci: replace d11 cluster url in UploadSourcemaps (#1122) * fix(android): resolve private views through UI manager directly (#1121) * feat: support switching to native network interception (#1120) * feat(example): Add more sdk crashes buttons * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * feat(example): Add more sdk crashes buttons * fix dev merge issue * feat_add_crash_buttons * feat_add_crash_buttons * feat_add_crash_buttons * fix: PlatformListTile typo name --------- Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com> Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com> Co-authored-by: AbdElHamid Nasser <anasser@instabug.com> * feat_add_setNDKCrashesEnabled * fix android_testing issue * rename_test_cases * fix_pr_comments * feat/add-ndk-demo-crash-buttons * chore: add ChangeLog changes * Update CHANGELOG.md Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com> * fix:lint issue * fix: CHANGELOG typo issue Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com> --------- Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com> Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com> Co-authored-by: AbdElHamid Nasser <anasser@instabug.com>

* feat(example): add nested complex views (#1111) Jira ID: MOB-13737 * fix hybrid mode code push version init (#1108) * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * ci: migrate macos machines to m1 (#1114) * feat: support identify user by id (#1115) Jira ID: MOB-13746 * ci: replace d11 cluster url in UploadSourcemaps (#1122) * fix(android): resolve private views through UI manager directly (#1121) * feat: support switching to native network interception (#1120) * feat(example): Add more sdk crashes buttons * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * feat(example): Add more sdk crashes buttons * fix dev merge issue * feat_add_crash_buttons * feat_add_crash_buttons * feat_add_crash_buttons * fix: PlatformListTile typo name --------- Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com> Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com> Co-authored-by: AbdElHamid Nasser <anasser@instabug.com>

* feat_add_setNDKCrashesEnabled * fix android_testing issue * rename_test_cases * fix_pr_comments * feat/add-ndk-demo-crash-buttons * chore: add ChangeLog changes * Update CHANGELOG.md Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com> * feat: add more crash scenarios to example app (#1131) * feat(example): add nested complex views (#1111) Jira ID: MOB-13737 * fix hybrid mode code push version init (#1108) * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * ci: migrate macos machines to m1 (#1114) * feat: support identify user by id (#1115) Jira ID: MOB-13746 * ci: replace d11 cluster url in UploadSourcemaps (#1122) * fix(android): resolve private views through UI manager directly (#1121) * feat: support switching to native network interception (#1120) * feat(example): Add more sdk crashes buttons * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * feat(example): Add more sdk crashes buttons * fix dev merge issue * feat_add_crash_buttons * feat_add_crash_buttons * feat_add_crash_buttons * fix: PlatformListTile typo name --------- Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com> Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com> Co-authored-by: AbdElHamid Nasser <anasser@instabug.com> * feat_add_setNDKCrashesEnabled * fix android_testing issue * rename_test_cases * fix_pr_comments * feat/add-ndk-demo-crash-buttons * chore: add ChangeLog changes * Update CHANGELOG.md Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com> * fix:lint issue * fix: CHANGELOG typo issue Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com> --------- Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com> Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com> Co-authored-by: AbdElHamid Nasser <anasser@instabug.com>

feat(example): Add nested complex views

fc299b9

Allows testing using complex nested views

abdelhamid-f-nasser requested review from a7medev and ahmedAlaaInstabug January 28, 2024 14:08

a7medev requested changes Jan 28, 2024

View reviewed changes

a7medev changed the title ~~feat(example): Add nested complex views~~ feat(example): add nested complex views Jan 28, 2024

abdelhamid-f-nasser requested a review from a7medev January 28, 2024 16:20

abdelhamid-f-nasser added 3 commits January 28, 2024 22:37

fix: resolve nexted view id error

ffc63d4

refactor: remove redundant PropsWithChildren

2513ae1

refactor: support passing ref to InputField

56fb01e

abdelhamid-f-nasser force-pushed the feat/example-nested-complex-views branch from 381be0f to 56fb01e Compare January 28, 2024 20:39

a7medev approved these changes Jan 29, 2024

View reviewed changes

abdelhamid-f-nasser merged commit 9a8703d into dev Jan 29, 2024

abdelhamid-f-nasser deleted the feat/example-nested-complex-views branch January 29, 2024 08:38

HeshamMegid pushed a commit that referenced this pull request Feb 10, 2024

feat(example): add nested complex views (#1111)

94cdc17

Jira ID: MOB-13737

ahmedAlaaInstabug pushed a commit that referenced this pull request Feb 19, 2024

feat(example): add nested complex views (#1111)

180efc2

Jira ID: MOB-13737

ahmedAlaaInstabug pushed a commit that referenced this pull request Feb 20, 2024

feat(example): add nested complex views (#1111)

c611f39

Jira ID: MOB-13737

ahmedAlaaInstabug pushed a commit that referenced this pull request Feb 20, 2024

feat(example): add nested complex views (#1111)

ed9dced

Jira ID: MOB-13737

abdelhamid-f-nasser self-assigned this Feb 20, 2024

abdelhamid-f-nasser mentioned this pull request Feb 28, 2024

feat: add runtime code push version API (#1143) #1158

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(example): add nested complex views #1111

feat(example): add nested complex views #1111

Uh oh!

abdelhamid-f-nasser commented Jan 28, 2024

Uh oh!

mnoseir commented Jan 28, 2024 •

edited

Loading

Uh oh!

a7medev left a comment

Uh oh!

a7medev Jan 28, 2024

Uh oh!

a7medev Jan 28, 2024

Uh oh!

a7medev Jan 28, 2024

Uh oh!

abdelhamid-f-nasser Jan 28, 2024 •

edited

Loading

Uh oh!

abdelhamid-f-nasser commented Jan 28, 2024

Uh oh!

abdelhamid-f-nasser commented Jan 28, 2024

Uh oh!

a7medev left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		import { KeyboardTypeOptions, StyleSheet, TextInput } from 'react-native';

		interface InputFieldProps extends PropsWithChildren {

feat(example): add nested complex views #1111

feat(example): add nested complex views #1111

Uh oh!

Conversation

abdelhamid-f-nasser commented Jan 28, 2024

Description of the change

Type of change

Related issues

Checklists

Development

Code review

Uh oh!

mnoseir commented Jan 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

a7medev left a comment

Choose a reason for hiding this comment

Uh oh!

a7medev Jan 28, 2024

Choose a reason for hiding this comment

Uh oh!

a7medev Jan 28, 2024

Choose a reason for hiding this comment

Uh oh!

a7medev Jan 28, 2024

Choose a reason for hiding this comment

Uh oh!

abdelhamid-f-nasser Jan 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abdelhamid-f-nasser commented Jan 28, 2024

Uh oh!

abdelhamid-f-nasser commented Jan 28, 2024

Uh oh!

a7medev left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mnoseir commented Jan 28, 2024 •

edited

Loading

abdelhamid-f-nasser Jan 28, 2024 •

edited

Loading