Skip to content

Conversation

@ahmedAlaaInstabug
Copy link
Contributor

@ahmedAlaaInstabug ahmedAlaaInstabug commented Feb 11, 2024

Description of the change

  1. add new crash scenarios to example app

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

JIRA Ticket:

  • MOB-13634
  • APM-19646

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@ahmedAlaaInstabug ahmedAlaaInstabug self-assigned this Feb 11, 2024
…ns' into feat/add-more-demo-crashes-buttons

# Conflicts:
#	CHANGELOG.md
#	examples/default/src/screens/user-steps/BasicComponentsScreen.tsx
@ahmedAlaaInstabug ahmedAlaaInstabug changed the title Feat/add more demo crashes buttons Feat: add more crash scenarios to example app Feb 11, 2024
@ahmedAlaaInstabug ahmedAlaaInstabug changed the title Feat: add more crash scenarios to example app feat: add more crash scenarios to example app Feb 11, 2024
@mnoseir
Copy link

mnoseir commented Feb 13, 2024

Coverage Report

Label Coverage Status
JavaScript 96.2%
Android 47.2%
iOS 41.3%

Generated by 🚫 dangerJS against fc3409a

Base automatically changed from dev to master February 15, 2024 12:31
@ahmedAlaaInstabug ahmedAlaaInstabug changed the base branch from master to dev February 15, 2024 13:12
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort 👍 💪 , please check the file name change request (it's a typo I did in the original PR 🙏 🙈 ).

@ahmedAlaaInstabug ahmedAlaaInstabug merged commit 3ab63ab into dev Feb 18, 2024
@ahmedAlaaInstabug ahmedAlaaInstabug deleted the feat/add-more-demo-crashes-buttons branch February 18, 2024 14:12
ahmedAlaaInstabug added a commit that referenced this pull request Feb 19, 2024
* feat_add_setNDKCrashesEnabled

* fix android_testing issue

* rename_test_cases

* fix_pr_comments

* feat/add-ndk-demo-crash-buttons

* chore: add ChangeLog changes

* Update CHANGELOG.md

Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com>

* feat: add more crash scenarios to example app (#1131)

* feat(example): add nested complex views (#1111)

Jira ID: MOB-13737

* fix hybrid mode code push version init (#1108)

* chore(android): ignore jetbrains ide run configurations (#1110)

Jira ID: MOB-13736

* ci: migrate macos machines to m1 (#1114)

* feat: support identify user by id (#1115)

Jira ID: MOB-13746

* ci: replace  d11 cluster url in UploadSourcemaps (#1122)

* fix(android): resolve private views through UI manager directly (#1121)

* feat: support switching to native network interception (#1120)

* feat(example): Add more sdk crashes buttons

* chore(android): ignore jetbrains ide run configurations (#1110)

Jira ID: MOB-13736

* feat(example): Add more sdk crashes buttons

* fix dev merge issue

* feat_add_crash_buttons

* feat_add_crash_buttons

* feat_add_crash_buttons

* fix: PlatformListTile typo  name

---------

Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com>
Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com>
Co-authored-by: AbdElHamid Nasser <anasser@instabug.com>

* feat_add_setNDKCrashesEnabled

* fix android_testing issue

* rename_test_cases

* fix_pr_comments

* feat/add-ndk-demo-crash-buttons

* chore: add ChangeLog changes

* Update CHANGELOG.md

Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com>

* fix:lint issue

* fix:  CHANGELOG typo issue

Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com>

---------

Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com>
Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com>
Co-authored-by: AbdElHamid Nasser <anasser@instabug.com>
ahmedAlaaInstabug added a commit that referenced this pull request Feb 20, 2024
* feat(example): add nested complex views (#1111)

Jira ID: MOB-13737

* fix hybrid mode code push version init (#1108)

* chore(android): ignore jetbrains ide run configurations (#1110)

Jira ID: MOB-13736

* ci: migrate macos machines to m1 (#1114)

* feat: support identify user by id (#1115)

Jira ID: MOB-13746

* ci: replace  d11 cluster url in UploadSourcemaps (#1122)

* fix(android): resolve private views through UI manager directly (#1121)

* feat: support switching to native network interception (#1120)

* feat(example): Add more sdk crashes buttons

* chore(android): ignore jetbrains ide run configurations (#1110)

Jira ID: MOB-13736

* feat(example): Add more sdk crashes buttons

* fix dev merge issue

* feat_add_crash_buttons

* feat_add_crash_buttons

* feat_add_crash_buttons

* fix: PlatformListTile typo  name

---------

Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com>
Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com>
Co-authored-by: AbdElHamid Nasser <anasser@instabug.com>
ahmedAlaaInstabug added a commit that referenced this pull request Feb 20, 2024
* feat_add_setNDKCrashesEnabled

* fix android_testing issue

* rename_test_cases

* fix_pr_comments

* feat/add-ndk-demo-crash-buttons

* chore: add ChangeLog changes

* Update CHANGELOG.md

Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com>

* feat: add more crash scenarios to example app (#1131)

* feat(example): add nested complex views (#1111)

Jira ID: MOB-13737

* fix hybrid mode code push version init (#1108)

* chore(android): ignore jetbrains ide run configurations (#1110)

Jira ID: MOB-13736

* ci: migrate macos machines to m1 (#1114)

* feat: support identify user by id (#1115)

Jira ID: MOB-13746

* ci: replace  d11 cluster url in UploadSourcemaps (#1122)

* fix(android): resolve private views through UI manager directly (#1121)

* feat: support switching to native network interception (#1120)

* feat(example): Add more sdk crashes buttons

* chore(android): ignore jetbrains ide run configurations (#1110)

Jira ID: MOB-13736

* feat(example): Add more sdk crashes buttons

* fix dev merge issue

* feat_add_crash_buttons

* feat_add_crash_buttons

* feat_add_crash_buttons

* fix: PlatformListTile typo  name

---------

Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com>
Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com>
Co-authored-by: AbdElHamid Nasser <anasser@instabug.com>

* feat_add_setNDKCrashesEnabled

* fix android_testing issue

* rename_test_cases

* fix_pr_comments

* feat/add-ndk-demo-crash-buttons

* chore: add ChangeLog changes

* Update CHANGELOG.md

Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com>

* fix:lint issue

* fix:  CHANGELOG typo issue

Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com>

---------

Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com>
Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com>
Co-authored-by: AbdElHamid Nasser <anasser@instabug.com>
abdelhamid-f-nasser added a commit that referenced this pull request Feb 27, 2024
* feat(example): add nested complex views (#1111)

Jira ID: MOB-13737

* fix hybrid mode code push version init (#1108)

* chore(android): ignore jetbrains ide run configurations (#1110)

Jira ID: MOB-13736

* ci: migrate macos machines to m1 (#1114)

* feat: support identify user by id (#1115)

Jira ID: MOB-13746

* ci: replace  d11 cluster url in UploadSourcemaps (#1122)

* fix(android): resolve private views through UI manager directly (#1121)

* feat: support switching to native network interception (#1120)

* feat(example): Add more sdk crashes buttons

* chore(android): ignore jetbrains ide run configurations (#1110)

Jira ID: MOB-13736

* feat(example): Add more sdk crashes buttons

* fix dev merge issue

* feat_add_crash_buttons

* feat_add_crash_buttons

* feat_add_crash_buttons

* fix: PlatformListTile typo  name

---------

Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com>
Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com>
Co-authored-by: AbdElHamid Nasser <anasser@instabug.com>
abdelhamid-f-nasser added a commit that referenced this pull request Feb 28, 2024
* feat(example): add nested complex views (#1111)

Jira ID: MOB-13737

* fix hybrid mode code push version init (#1108)

* chore(android): ignore jetbrains ide run configurations (#1110)

Jira ID: MOB-13736

* ci: migrate macos machines to m1 (#1114)

* feat: support identify user by id (#1115)

Jira ID: MOB-13746

* ci: replace  d11 cluster url in UploadSourcemaps (#1122)

* fix(android): resolve private views through UI manager directly (#1121)

* feat: support switching to native network interception (#1120)

* feat(example): Add more sdk crashes buttons

* chore(android): ignore jetbrains ide run configurations (#1110)

Jira ID: MOB-13736

* feat(example): Add more sdk crashes buttons

* fix dev merge issue

* feat_add_crash_buttons

* feat_add_crash_buttons

* feat_add_crash_buttons

* fix: PlatformListTile typo  name

---------

Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com>
Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com>
Co-authored-by: AbdElHamid Nasser <anasser@instabug.com>
abdelhamid-f-nasser added a commit that referenced this pull request Feb 28, 2024
* feat(example): add nested complex views (#1111)

Jira ID: MOB-13737

* fix hybrid mode code push version init (#1108)

* chore(android): ignore jetbrains ide run configurations (#1110)

Jira ID: MOB-13736

* ci: migrate macos machines to m1 (#1114)

* feat: support identify user by id (#1115)

Jira ID: MOB-13746

* ci: replace  d11 cluster url in UploadSourcemaps (#1122)

* fix(android): resolve private views through UI manager directly (#1121)

* feat: support switching to native network interception (#1120)

* feat(example): Add more sdk crashes buttons

* chore(android): ignore jetbrains ide run configurations (#1110)

Jira ID: MOB-13736

* feat(example): Add more sdk crashes buttons

* fix dev merge issue

* feat_add_crash_buttons

* feat_add_crash_buttons

* feat_add_crash_buttons

* fix: PlatformListTile typo  name

---------

Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com>
Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com>
Co-authored-by: AbdElHamid Nasser <anasser@instabug.com>
abdelhamid-f-nasser added a commit that referenced this pull request Feb 28, 2024
* feat_add_setNDKCrashesEnabled

* fix android_testing issue

* rename_test_cases

* fix_pr_comments

* feat/add-ndk-demo-crash-buttons

* chore: add ChangeLog changes

* Update CHANGELOG.md

Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com>

* feat: add more crash scenarios to example app (#1131)

* feat(example): add nested complex views (#1111)

Jira ID: MOB-13737

* fix hybrid mode code push version init (#1108)

* chore(android): ignore jetbrains ide run configurations (#1110)

Jira ID: MOB-13736

* ci: migrate macos machines to m1 (#1114)

* feat: support identify user by id (#1115)

Jira ID: MOB-13746

* ci: replace  d11 cluster url in UploadSourcemaps (#1122)

* fix(android): resolve private views through UI manager directly (#1121)

* feat: support switching to native network interception (#1120)

* feat(example): Add more sdk crashes buttons

* chore(android): ignore jetbrains ide run configurations (#1110)

Jira ID: MOB-13736

* feat(example): Add more sdk crashes buttons

* fix dev merge issue

* feat_add_crash_buttons

* feat_add_crash_buttons

* feat_add_crash_buttons

* fix: PlatformListTile typo  name

---------

Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com>
Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com>
Co-authored-by: AbdElHamid Nasser <anasser@instabug.com>

* feat_add_setNDKCrashesEnabled

* fix android_testing issue

* rename_test_cases

* fix_pr_comments

* feat/add-ndk-demo-crash-buttons

* chore: add ChangeLog changes

* Update CHANGELOG.md

Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com>

* fix:lint issue

* fix:  CHANGELOG typo issue

Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com>

---------

Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com>
Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com>
Co-authored-by: AbdElHamid Nasser <anasser@instabug.com>
abdelhamid-f-nasser added a commit that referenced this pull request Feb 28, 2024
* feat(example): add nested complex views (#1111)

Jira ID: MOB-13737

* fix hybrid mode code push version init (#1108)

* chore(android): ignore jetbrains ide run configurations (#1110)

Jira ID: MOB-13736

* ci: migrate macos machines to m1 (#1114)

* feat: support identify user by id (#1115)

Jira ID: MOB-13746

* ci: replace  d11 cluster url in UploadSourcemaps (#1122)

* fix(android): resolve private views through UI manager directly (#1121)

* feat: support switching to native network interception (#1120)

* feat(example): Add more sdk crashes buttons

* chore(android): ignore jetbrains ide run configurations (#1110)

Jira ID: MOB-13736

* feat(example): Add more sdk crashes buttons

* fix dev merge issue

* feat_add_crash_buttons

* feat_add_crash_buttons

* feat_add_crash_buttons

* fix: PlatformListTile typo  name

---------

Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com>
Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com>
Co-authored-by: AbdElHamid Nasser <anasser@instabug.com>
abdelhamid-f-nasser added a commit that referenced this pull request Feb 28, 2024
* feat_add_setNDKCrashesEnabled

* fix android_testing issue

* rename_test_cases

* fix_pr_comments

* feat/add-ndk-demo-crash-buttons

* chore: add ChangeLog changes

* Update CHANGELOG.md

Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com>

* feat: add more crash scenarios to example app (#1131)

* feat(example): add nested complex views (#1111)

Jira ID: MOB-13737

* fix hybrid mode code push version init (#1108)

* chore(android): ignore jetbrains ide run configurations (#1110)

Jira ID: MOB-13736

* ci: migrate macos machines to m1 (#1114)

* feat: support identify user by id (#1115)

Jira ID: MOB-13746

* ci: replace  d11 cluster url in UploadSourcemaps (#1122)

* fix(android): resolve private views through UI manager directly (#1121)

* feat: support switching to native network interception (#1120)

* feat(example): Add more sdk crashes buttons

* chore(android): ignore jetbrains ide run configurations (#1110)

Jira ID: MOB-13736

* feat(example): Add more sdk crashes buttons

* fix dev merge issue

* feat_add_crash_buttons

* feat_add_crash_buttons

* feat_add_crash_buttons

* fix: PlatformListTile typo  name

---------

Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com>
Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com>
Co-authored-by: AbdElHamid Nasser <anasser@instabug.com>

* feat_add_setNDKCrashesEnabled

* fix android_testing issue

* rename_test_cases

* fix_pr_comments

* feat/add-ndk-demo-crash-buttons

* chore: add ChangeLog changes

* Update CHANGELOG.md

Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com>

* fix:lint issue

* fix:  CHANGELOG typo issue

Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com>

---------

Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com>
Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com>
Co-authored-by: AbdElHamid Nasser <anasser@instabug.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants