Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem sets already alphabetized. Updating TODO. #1671

Merged
merged 4 commits into from
Oct 28, 2015
Merged

Problem sets already alphabetized. Updating TODO. #1671

merged 4 commits into from
Oct 28, 2015

Conversation

DavidMetcalfe
Copy link
Contributor

No description provided.

@onebree
Copy link
Contributor

onebree commented Oct 28, 2015

When you can, please squash the commits into 1. If you need help or instruction, let me know!


## React
* [React Tutorial](https://facebook.github.io/react/docs/tutorial.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you accidentally deleted this link.

@vhf
Copy link
Member

vhf commented Oct 28, 2015

Thanks for your PR, looks almost good to me! 👍

@onebree I still prefer atomic commits for this project, as I said here last week. :) (tl;dr: please don't squash if you can avoid it)

vhf added a commit that referenced this pull request Oct 28, 2015
Problem sets already alphabetized. Updating TODO.
@vhf vhf merged commit 85b38e1 into EbookFoundation:master Oct 28, 2015
@onebree
Copy link
Contributor

onebree commented Oct 28, 2015

@vhf I totally overlooked that comment, sorry. Just trying to help!

@vhf
Copy link
Member

vhf commented Oct 28, 2015

No problem! Your help is much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants