Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed dead links and added http/https #1656

Closed
wants to merge 21 commits into from
Closed

fixed dead links and added http/https #1656

wants to merge 21 commits into from

Conversation

G-Square
Copy link
Contributor

No description provided.

@@ -1082,6 +1087,7 @@ Original Source: [List of freely available programming books](http://web.archive
* [Learn CSS Layout](http://learnlayout.com/)
* [Scalable and Modular Architecture for CSS](http://smacss.com) - Jonathan Snook
* [Web Audio API](http://chimera.labs.oreilly.com/books/1234000001552) - Boris Smus
* [What Is HTML5?](http://shop.oreilly.com/product/0636920021049.do) - Brett McLaughlin
* [Adaptive Web Design] (http://adaptivewebdesign.info/1st-edition/) - Aaron Gustafson
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you did not submit this link, but can you ABC order it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be a good idea if someone would write a format validator script (python,ruby,etc) to take care of this before pull request. It would take care of common problems like spaces , ] ( and order all sections accordingly. And any other format problem @vhf would like to add.

@onebree
Copy link
Contributor

onebree commented Oct 23, 2015

If you are familiar with command-line git, please squash all these commits into one. Every time you hit "save" on Github, it creates 1 commit.

Also, I do not see any additions of http/https to links. Do you just mean you added more resources?

@vhf
Copy link
Member

vhf commented Oct 23, 2015

For this kind of project, I tend to prefer one commit per resource addition / deletion.

But if anyone finds it tedious when adding several resources, one big commit is also fine for me. I don't want to enforce strict commit rules. But if we can avoid squashing, I still prefer one commit per link.

@G-Square
Copy link
Contributor Author

I added http and https to some commits, this was missing in closed pull request #1652 (I deleted my fork).
And removed some of the links that stopped working for some reason.
Will keep squash in mind, Thanks @onebree.

@vhf
Copy link
Member

vhf commented Nov 17, 2015

I did my best trying to merge this patch, but did not succeed.

error: patch failed: free-programming-books.md:1520
error: free-programming-books.md: patch does not apply

@vhf vhf closed this Nov 17, 2015
@onebree
Copy link
Contributor

onebree commented Nov 17, 2015

@vhf is this patch applied somewhere, though? In general, why would a patch not apply in git? Is a patch different than a merge to master?

@vhf
Copy link
Member

vhf commented Nov 17, 2015

Unfortunately I'm note sure. I could have fought a bit longer with git, and probably would have found a solution. But since @G-Square 's branch does not exist anymore, and git does not want me to apply the patch, I'm a bit lost. I'll reopen and do my best.

@vhf
Copy link
Member

vhf commented Nov 17, 2015

Hmm, unfortunately github does not allow me to reopen the PR. When I hover the "Reopen" button, it says "The repository that submitted this pull request has been deleted". I guess I'll have to go through the changes and apply them manually when it still applies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants