Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to create-react-app 1.0.17 #21

Merged
merged 84 commits into from
Feb 9, 2018
Merged

Update to create-react-app 1.0.17 #21

Changes from 1 commit
Commits
Show all changes
84 commits
Select commit Hold shift + click to select a range
1df1610
Fix error overlay 'Object.assign' issue in IE by including polyfills …
tharakawj Sep 1, 2017
270b1dc
Strip hash from chunk file name (#3049)
esturcke Sep 1, 2017
51d0df4
Rename Overlay to ErrorOvelay (#3051)
tharakawj Sep 2, 2017
6644054
provide empty mock for child_process so importing libraries with it w…
anthonyalayo Sep 2, 2017
8a72a31
Make error overlay filename configurable (#3028)
jaredpalmer Sep 2, 2017
f65a1a9
Add missing slash
gaearon Sep 2, 2017
efeabee
Changelog for 1.0.13
gaearon Sep 2, 2017
c22dc70
Publish
gaearon Sep 2, 2017
e8b58ed
Set travis config to use 'precise' ci environment
tharakawj Sep 3, 2017
b17fa41
Update eslint-config npm install command (#3072)
jdcrensh Sep 6, 2017
634dadb
Unmapper Windows compatibility (#3079)
Timer Sep 6, 2017
fcb6dc5
run npm 5.4.0 in CI (#3026)
viankakrisna Sep 7, 2017
5e300ce
Reload the page when an error has occurred (#3098)
Timer Sep 9, 2017
44cfbcc
Rerun prettier and pin version (#3058)
viankakrisna Sep 10, 2017
12f1a8e
Clean target directory before compiling overlay (#3102)
Timer Sep 11, 2017
1faee66
Auto-detect running editor on Linux for error overlay (#3077)
gulderov Sep 11, 2017
eed708a
Updated react-error-overlay to latest Flow (0.54.0) (#3065)
duvet86 Sep 11, 2017
0e064b3
Revert "run npm 5.4.0 in CI (#3026)" (#3107)
viankakrisna Sep 12, 2017
206f9e8
Resolved issue #2971 (#2989)
Sep 13, 2017
89bf273
Link local react-error-overlay package in kitchensink test
tharakawj Sep 16, 2017
2cff8db
Display pid in already running message (#3131)
Pajn Sep 16, 2017
b67ef01
Update unclear wording in webpack config docs (#3160)
Sep 20, 2017
700c8cd
Part of class fields to stage 3 (#2908)
rickbeerendonk Sep 20, 2017
376fd43
Update webpack-dev-server to 2.8.2 (#3157)
nikolas Sep 22, 2017
1491d46
Add link to active CSS modules discussion (#3163)
zikaari Sep 22, 2017
2e82ebb
BSD+Patents -> MIT (#3189)
sophiebits Sep 26, 2017
9e966b4
Changelog for 1.0.14
Timer Sep 27, 2017
fedc539
Fix license comments
Timer Sep 27, 2017
b2c0b3f
Publish
Timer Sep 27, 2017
6e5e227
Improve grammar in README (#3211)
Mohamed3on Sep 29, 2017
a34701b
Correct manual proxy documentation (#3185)
robertpanzer Sep 29, 2017
8c8bbca
Minor change to highlight dev proxy behaviour (#3075)
davidjb Sep 29, 2017
c003583
More spec compliant HTML template (#2914)
Hurtak Sep 29, 2017
1e98d0f
Watch for changes in `src/**/node_modules` (#3230)
xjlim Oct 3, 2017
f498547
Fix package management link in README (#3227)
nishina555 Oct 3, 2017
01a0d73
Fix Windows compatibility (#3232)
Timer Oct 3, 2017
cd3d04b
Make error overlay to run in the context of the iframe (#3142)
tharakawj Oct 3, 2017
62f0a83
Update url-loader to 0.6.2 for mime ReDoS vuln (#3246)
joshwiens Oct 5, 2017
a0030fc
Update style-loader and disable inclusion of its HMR code in builds (…
insin Oct 6, 2017
00ed100
Add click-to-open support for build errors (#3100)
tharakawj Oct 6, 2017
360fa27
`react-error-overlay` has no dependencies now (#3263)
Timer Oct 11, 2017
86b4b6a
Add external links to deployment services (#3265)
aericson Oct 11, 2017
9ce144e
Add warning when using `react-error-overlay` in production (#3264)
Timer Oct 11, 2017
991b092
Use production React version for bundled overlay (#3267)
Timer Oct 11, 2017
2d0ef6a
Fix dead link to Jest "expect" docs (#3289)
alexkrolick Oct 17, 2017
1a3017b
Update README.md
Timer Oct 17, 2017
a0c515c
Update link to Jest Expect docs (#3303)
jbranchaud Oct 19, 2017
72a02c7
Add jest coverage configuration docs (#3279)
mattphillips Oct 21, 2017
54f7da9
Update `eslint-plugin-react` (#3146)
lpalmes Oct 23, 2017
aa322d0
Clarify the npm precompilation advice
gaearon Oct 26, 2017
4d4cbf0
Use a simpler string replacement for the overlay
gaearon Oct 28, 2017
c66c296
Use React 16 in development
gaearon Oct 28, 2017
fe4dc74
Polyfill rAF in test environment (#3340)
gaearon Oct 28, 2017
0f5deb6
Update appveyor.cleanup-cache.txt
gaearon Oct 28, 2017
c51258b
recommend react-snap; react-snapshot isn't upgraded for React 16 (#3328)
aaronshaf Oct 28, 2017
d98b756
Bump dependencies (#3342)
gaearon Oct 28, 2017
8c7b6e7
Fix favicon sizes value in manifest (#3287)
ryansully Oct 28, 2017
1fa16ac
Make uglify work in Safari 10.0 - fixes #3280 (#3281)
satyavh Oct 28, 2017
4add16d
Add documentation for Enzyme 3 integration (#3286)
ryansully Oct 28, 2017
5c8000f
Add `.mjs` support (#3239)
Timer Oct 28, 2017
70e0c08
Remove output.path from dev webpack config (#3158)
nikolas Oct 28, 2017
15d8e53
Remove an useless negation in registerServiceWorker.js (#3150)
dunglas Oct 28, 2017
5a336ad
Updating the Service Worker opt-out documentation (#3108)
captDaylight Oct 28, 2017
fc885a0
start using npm-run-all to build scss and js (#2957)
shime Oct 28, 2017
e05a5fe
Mention that start_url needs to be "." for client side routing
foochu Oct 28, 2017
345f550
Fix for add .gitattributes file #3080 (#3122)
ijajmulani Oct 28, 2017
de1beec
Stop using `npm link` in tests (#3345)
Timer Oct 30, 2017
1a61cd4
Add preflight CWD check for npm (#3355)
gaearon Oct 30, 2017
5e7b967
Publish
gaearon Oct 30, 2017
87643fd
CLI@1.4.2
gaearon Oct 30, 2017
e62bfdd
Replace template literal; fixes #3367 (#3368)
felthy Oct 31, 2017
a9257ec
Changelog for 1.0.15 (#3357)
gaearon Oct 30, 2017
1740c3f
Update favicon description (#3374)
piotr-cz Oct 31, 2017
7ae6ab1
Changelog for 1.0.16 (#3376)
gaearon Oct 31, 2017
b8e6ba3
Reorder publishing instructions
gaearon Oct 31, 2017
dc95d18
Publish
gaearon Oct 31, 2017
74c523c
Update README.md (#3392)
ryanswapp Nov 2, 2017
35fa70e
Update VS Code debug configuration (#3400)
auchenberg Nov 3, 2017
2cb4871
Add link to VS Code troubleshooting guide (#3399)
auchenberg Nov 3, 2017
90c83f7
Fix grammar in README (#3394)
lorensr Nov 3, 2017
5811d55
Use new WebpackDevServer option (#3401)
gaearon Nov 3, 2017
cfbd468
Add 1.0.17 changelog (#3402)
gaearon Nov 3, 2017
4b55193
Publish
gaearon Nov 3, 2017
3b03e00
Merge tag 'v1.0.17' into zeal
frank-west-iii Dec 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Display pid in already running message (facebook#3131) 
Fixes facebook#3106
  • Loading branch information
@Pajn @Timer
Pajn authored and Timer committed Sep 16, 2017
commit 2cff8db00b31efd7d6ce3da32b7e877458d3c47f
7 changes: 5 additions & 2 deletions packages/react-dev-utils/getProcessForPort.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,11 @@ function getProcessCommand(processId, processDirectory) {
execOptions
);

command = command.replace(/\n$/, '')

if (isProcessAReactApp(command)) {
const packageName = getPackageNameInDirectory(processDirectory);
return packageName ? packageName + '\n' : command;
return packageName ? packageName : command;
} else {
return command;
}
Expand All @@ -68,7 +70,8 @@ function getProcessForPort(port) {
var processId = getProcessIdOnPort(port);
var directory = getDirectoryOfProcessById(processId);
var command = getProcessCommand(processId, directory);
return chalk.cyan(command) + chalk.blue(' in ') + chalk.cyan(directory);
return chalk.cyan(command) + chalk.grey(' (pid ' + processId + ')\n') +
chalk.blue(' in ') + chalk.cyan(directory);
} catch (e) {
return null;
}
Expand Down