Update to create-react-app 1.0.17 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…before webpack client (facebook#3046)
* Make error overlay file configurable * Add fallback filename
The `npm install` script for outside usage instructions is outdated. Updated to match the package's current peer dependencies.
* Switch to unix path separators before normalizing path for Windows compatibility * Add comment for posterity * Revert "Add comment for posterity" This reverts commit 742bace. * Strictly add comment
* run npm 5.4.0 in CI * run npm cache clean with --force in CI * use link instead of install * Update e2e-installs.sh * Update e2e-kitchensink.sh * Update e2e-simple.sh
* Reload the page when an error has occurred Fixes facebook#3096 * Use a global boolean instead
* rerun prettier for all files * pin prettier to 1.6.1
* Clean target directory before compiling overlay * Use rimraf
* Auto-detect running editor on Linux for error overlay Basic support of auto detecting running editor for facebook#2636. Tested on Ubuntu 16.04. It detects few editors. JetBrains products should start by wrapper like /usr/local/bin/webstorm. Otherwise it takes a lot of time to open editor. * Comments fixed. * List all processes owned by you * Comment rewording
* Updated react-error-overlay to latest Flow (0.54.0) * Revert "Updated react-error-overlay to latest Flow (0.54.0)" This reverts commit 6deaffb. * Fixed unit tests. * Updated code as per code review. * Fixed code as per code review. * Updated the code as per review.
This reverts commit fcb6dc5.
* Resolved issue facebook#2971 - changed h2 to h1 in template to adhere to accessibility guidelines. - Added h1 styles to maintain same font size. * Added header tag to template Corrected templete to use semantically correct header tag for header instead of div * Added className for App-title - Added className="App-title" to h1 tag - Changed CSS selector to target class instead of element
* Class fields to stage 3 Per 2017.07.27 TC39 tc39/proposals@0bbbb08 * Be explicit that only the public part of the unified field proposal is available.
It doesn't look like there is any backwards incompatibility: https://github.com/webpack/webpack-dev-server/releases
* Add link to active CSS modules discussion * Update README.md
* File headers BSD+Patents -> MIT * BSD+Patents -> MIT
Also, clarify hot reloading a bit.
According to this parameter's comment, it's unused but webpack-dev-server crashes without it. However, webpack-dev-server is running fine for me without this parameter.
instead of using `&&` to run multiple commands in `package.json`, guide users to use `npm-run-all`
* Change template manifest start_url to dot to make it react-router friendly * Revert "Change template manifest start_url to dot to make it react-router friendly" This reverts commit 02f53e8. * Add a note about PWA manifest and client-side routing
* Try a custom function * fix path * install rsync * Test with node 8 * Ensure package is removed from the tree * Remove ours * matching functions * try cygwin * try c:/ * sigh * Try /cygdrive/ * Try /cygdrive/ * Revert "Try /cygdrive/" This reverts commit ab1ed779456d39bedbdb128a7aec3bb88b8eeb1c. * Use sub-optimal copy * Remove rsync install * Fix variable * Continue on err * Don't link react-scripts, lol * run yarn after eject * re-enable cleanup * uninstall yarn * try with force * appveyor ... seriously? * swallow bad eject * remove eject error swallow * Revert "run yarn after eject" This reverts commit eebf1dbc19aeb6e1f66d5ec27bda2d076bea0956. * Run yarn after eject * add a comment
* Add preflight CWD check for npm * Typos
* Changelog for 1.0.15 * Update CHANGELOG.md * Update CHANGELOG.md
Fixed a small grammatical issue that I noticed while browsing the README today
* Add link to VS Code troubleshooting guide * Update README.md
"subway" by itself is not a proper noun
Conflicts: packages/react-scripts/config/webpack.config.dev.js packages/react-scripts/package.json packages/react-scripts/scripts/utils/createJestConfig.js
randycoulman
approved these changes
Dec 22, 2017
There was a problem hiding this comment.
Hard to tell what we had to do to bring this up-to-date, but seems legit.
Have there been any further changes to the CSS Modules PR since we last brought it in? If so, should those changes be part of this PR as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.