Make cursor appear when clicking after the last line of a file (#56) #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austincondiff
requested review from
thecoolwinter,
lukepistrol,
matthijseikelenboom and
Wouter01
matthijseikelenboom
previously approved these changes
Feb 17, 2023
This was
linked to
issues
Feb 17, 2023
thecoolwinter
approved these changes
Feb 17, 2023
thecoolwinter
requested changes
Feb 17, 2023
|
Looks awesome, I just left a comment about where to put the file like you asked. And one small change for finding the end range. Thank you! This has been needed for a while. Also yes the CE prefix is perfectly fine. |
…n to simplify textView range calculation (CodeEditApp#56)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
STTextViewController.swift, I created a subclass ofNSScrollViewto implement a custommouseDown(with event:)function. The function makes it so, if a click is detected within the ScrollView but out of the contained STTextView, the editor cursor is placed on the last index of the text.I created the subclass at the end of
STTextViewController.swift, but it should probably go to its own file; upon review I would like suggestions of where to place this file, as none of the current directories seem appropriate for it.Additionally, the name of the class is
CEScrollView(CEfor CodeEdit); I am not sure if there is a different naming convention customized subclasses.Related Issue
Checklist
Screenshots