Skip to content

🐞 Set a minimum height on the textview #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rishaandesai opened this issue Sep 6, 2022 · 1 comment · Fixed by #145
Closed

🐞 Set a minimum height on the textview #56

rishaandesai opened this issue Sep 6, 2022 · 1 comment · Fixed by #145
Assignees
@RenanGreca
Labels
bug Something isn't working editor good first issue Good for newcomers

Comments

@rishaandesai
Copy link

Set a minimum height on the textview so that:

  • Clicking outside of a line with text causes the cursor to appear
  • Clicking on a line in an empty file causes the cursor to show up on the first line
@lukepistrol lukepistrol added bug Something isn't working good first issue Good for newcomers editor labels Sep 6, 2022
@lukepistrol lukepistrol mentioned this issue Oct 4, 2022
Closed
@lukepistrol lukepistrol changed the title Set a minimum height on the textview 🐞 Set a minimum height on the textview Nov 22, 2022
@austincondiff austincondiff mentioned this issue Feb 16, 2023
Closed
@austincondiff austincondiff moved this from 🆕 New to 📋 Todo in CodeEdit Project Feb 16, 2023
RenanGreca added a commit to RenanGreca/CodeEditTextView that referenced this issue Feb 17, 2023
@RenanGreca
Make cursor appear when clicking after the last line of a file (CodeE…
910848e 
…ditApp#56)
@RenanGreca RenanGreca mentioned this issue Feb 17, 2023
Merged
5 tasks
@austincondiff austincondiff moved this from 📋 Todo to 🏃‍♂️ In Progress in CodeEdit Project Feb 17, 2023
@austincondiff austincondiff linked a pull request Feb 17, 2023 that will close this issue
Make cursor appear when clicking after the last line of a file (#56) #145
Merged
5 tasks
@austincondiff austincondiff mentioned this issue Feb 17, 2023
Closed
RenanGreca added a commit to RenanGreca/CodeEditTextView that referenced this issue Feb 18, 2023
@RenanGreca
Moved CEScrollView to separate file and used documentRange.endLocatio…
22b4ab7 
…n to simplify textView range calculation (CodeEditApp#56)
@RenanGreca
Copy link
Contributor

I did not comment here beforehand, but I'd like to be assigned to this issue as I have already started working on it in PR #145.

thecoolwinter pushed a commit that referenced this issue Feb 20, 2023
@RenanGreca
Make cursor appear when clicking after the last line of a file (#56) (#…
e7a082a 
…145)
@github-project-automation github-project-automation bot moved this from 🏃‍♂️ In Progress to 🏁 Complete in CodeEdit Project Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RenanGreca RenanGreca

Labels
bug Something isn't working editor good first issue Good for newcomers
Projects
CodeEdit Project
Status: 🏁 Complete
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make cursor appear when clicking after the last line of a file (#56) RenanGreca/CodeEditTextView
3 participants
@RenanGreca @lukepistrol @rishaandesai