-
Notifications
You must be signed in to change notification settings - Fork 8.2k
shields: nxp: lcd_par_s035: fix gt911 touch initialization #99029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
shields: nxp: lcd_par_s035: fix gt911 touch initialization #99029
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't you deffer the initialization of display & touch controllers and do the setup in the right order in the board's (or shield's, if that's a thing) board.c?
I really do not like seeing code in the touch controller driver that actually has nothing to do with it, and it's solving a problem created by the shield.
I don't see how deferred initialization fixes this. Whether you defer or not you still have to have the same patch @DerekSnell submitted here. |
|
Actually I think we added the ability to put code in shields, if I'm remembering correctly, and I think I understand @JarmouniA suggestion now. It could be possible to do this by deferred initialization and handle init in shield code. |
Defers init of GT911 touch, MIPI DBI, and display device drivers. lcd_par_s035_init() in shield.c now initializes these to control the GT911 INT_GPIO state during the Reset sequence. Signed-off-by: Derek Snell <derek.snell@nxp.com>
6581f53 to
72c317b
Compare
|
Hi @JarmouniA , |



Fixes #98876
Defers init of GT911 touch, MIPI DBI, and display device drivers.
lcd_par_s035_init()in shield.c now initializes these to control the GT911 INT_GPIO state during the Reset sequence.reset-gpiosproperty fromgt911node. The GT911 driver does not need to assert the Reset signal because the display driver asserts Reset before the GT911 driver initializes.Tested this fix on the following:
This capture is from the LCD_PAR_S035 with the FRDM_RW612 and this change applied. The GT911 INT_GPIO is driven low first, then the LCDIC display driver asserts Reset and INT_GPIO remains low through the init process.
