tests: bluetooth: tester: Fix VCS tests #99025
Open
+57
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Bluetooth Qualification
zephyrbot
requested review from
Thalley,
asbjornsabo,
babrsn,
fredrikdanebjer,
jhedberg,
jthm-ot,
larsgk,
nashif,
niym-ot and
sjanc
Frodevan
force-pushed
the
oct-3510-fix-vcs-tests
branch
from
6d8b90d to
b6689e3
Compare
Frodevan
force-pushed
the
oct-3510-fix-vcs-tests
branch
3 times, most recently
from
cb0dc63 to
cf08631
Compare
Thalley
requested changes
Nov 6, 2025
| #define BTP_VCS_VOL_DOWN 0x04 | ||
| #define BTP_VCS_MUTE 0x05 | ||
| #define BTP_VCS_UNMUTE 0x06 | ||
| #define BTP_VCS_REGISTER 0x07 |
There was a problem hiding this comment.
I would suggest to make this command contain the parameters (basically every value in struct bt_vcp_vol_rend_register_param except the callbacks), so that it's fully controlled by the upper tester / AutoPTS, instead of relying on some defaults set by the BT Tester. This allows AutoPTS to maintain the same values and behavior between different DUTs.
There was a problem hiding this comment.
I agree, and I am currently working on this.
Frodevan
force-pushed
the
oct-3510-fix-vcs-tests
branch
4 times, most recently
from
252edc6 to
768a4ee
Compare
Zephyr automatically sets the persisted flag for VCS if the volume is changed after the service is registered. As some of these PTS tests require a set volume with the flag cleared, the initial volume needs to be set before registering VCS. Signed-off-by: Frode van der Meeren <frode.vandermeeren@nordicsemi.no>
Frodevan
force-pushed
the
oct-3510-fix-vcs-tests
branch
from
768a4ee to
46e44ee
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zephyr automatically sets the persisted flag for VCS if the volume is changed after the service is registered. As some of these PTS tests require a set volume with the flag cleared, the initial volume needs to be set before registering VCS.
This PR is associated with auto-pts/auto-pts#1603